Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop $class param from View constructor #1791

Merged
merged 22 commits into from
May 21, 2022
Merged

Drop $class param from View constructor #1791

merged 22 commits into from
May 21, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented May 21, 2022

in favor of class.xxx seed syntax introduced in #1770

this change intends to make the code more readable and error proof

to find most places to update, use \[\s*+[^\[\]]+(?<!=> )'(\w| )+'(?! =>) regex

@mvorisek mvorisek force-pushed the stricter_add_class branch from 3ada5b7 to 83d9a20 Compare May 21, 2022 14:05
@mvorisek mvorisek force-pushed the stricter_add_class branch 2 times, most recently from a7ca761 to 490fb37 Compare May 21, 2022 14:56
@mvorisek mvorisek force-pushed the stricter_add_class branch from ad248b4 to d869b6e Compare May 21, 2022 14:59
@mvorisek mvorisek marked this pull request as ready for review May 21, 2022 17:59
@mvorisek mvorisek merged commit 113d5da into develop May 21, 2022
@mvorisek mvorisek deleted the stricter_add_class branch May 21, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant