-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic return type seed support #1679
Draft
mvorisek
wants to merge
1
commit into
develop
Choose a base branch
from
improve_seed_stan
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
improve_seed_stan
branch
from
October 11, 2021 15:35
beadcae
to
85c3866
Compare
mvorisek
changed the title
Update phpstan rules with dynamic return type seed support
Add dynamic return type seed support
Oct 11, 2021
mvorisek
force-pushed
the
improve_seed_stan
branch
6 times, most recently
from
October 11, 2021 16:39
09b0d70
to
cc2cb86
Compare
mvorisek
commented
Oct 11, 2021
phpstan.neon.dist
Outdated
@@ -56,10 +51,13 @@ parameters: | |||
message: '~^Call to an undefined method Atk4\\Ui\\View::addFields\(\)\.$~' | |||
- | |||
path: 'demos/form-control/calendar.php' | |||
message: '~^Call to an undefined method Atk4\\Ui\\Form\\Control::addAction\(\)\.$~' | |||
message: '~^Call to an undefined method Atk4\\Ui\\JsExpression::setDate\(\)\.$~' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo
mvorisek
force-pushed
the
improve_seed_stan
branch
4 times, most recently
from
October 11, 2021 21:03
5fcc15f
to
45d3fb7
Compare
mvorisek
force-pushed
the
improve_seed_stan
branch
7 times, most recently
from
October 17, 2021 15:42
49f8b6e
to
2451df7
Compare
mvorisek
force-pushed
the
improve_seed_stan
branch
2 times, most recently
from
October 18, 2021 08:59
5e2415b
to
b7d7c47
Compare
mvorisek
force-pushed
the
improve_seed_stan
branch
from
November 5, 2021 12:19
43e672f
to
16c41f6
Compare
mvorisek
force-pushed
the
improve_seed_stan
branch
from
August 28, 2022 15:33
16c41f6
to
442b934
Compare
mvorisek
commented
Aug 28, 2022
src/CardDeck.php
Outdated
@@ -148,6 +148,7 @@ public function setModel(Model $model, array $fields = null, array $extra = null | |||
|
|||
if ($count = $this->initPaginator()) { | |||
foreach ($this->model as $m) { | |||
/** @var Card */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo
mvorisek
force-pushed
the
improve_seed_stan
branch
from
August 28, 2022 15:58
ac1a434
to
0f6febd
Compare
mvorisek
force-pushed
the
improve_seed_stan
branch
from
December 22, 2022 14:34
0f6febd
to
d7ed918
Compare
mvorisek
force-pushed
the
improve_seed_stan
branch
from
February 10, 2023 13:58
d7ed918
to
c853b0e
Compare
mvorisek
force-pushed
the
improve_seed_stan
branch
4 times, most recently
from
September 7, 2023 11:40
4f79064
to
4c4eb82
Compare
mvorisek
force-pushed
the
improve_seed_stan
branch
from
September 22, 2023 22:35
4c4eb82
to
2e080c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.