Adjust to CS fixer v3.2 rules

[mvorisek]

No description provided.

[mvorisek]

@ibelar one unit test fix is needed, also please check

ui/src/VirtualPage.php

Line 152 in 4bf8f12

$this->getApp()->html->template->dangerouslySetHtml('Modals', $modalHtml);

not sure if Modals here needs any care too

[ibelar]

I will check. Should I push fix to this branch?

…

On Tue, Oct 5, 2021 at 10:43 AM Michael Voříšek ***@***.***> wrote: @ibelar <https://github.com/ibelar> one unit test fix is needed, also please check https://github.com/atk4/ui/blob/4bf8f12c4c72fcf21a3666b3007b081aeba6ba99/src/VirtualPage.php#L152 , not sure if Modals here needs any care too — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1670 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ2GPWPSEJW7RYOTA5KBHTUFMFKPANCNFSM5FLZE26A> .

-- Alain Belair

[mvorisek]

I will check. Should I push fix to this branch?

Yes, small almost typo fix.

Also, I wonder about the Right Panel name. What about Side Panel name instead? I belive it can be easily configured to be on the left side as well.

[ibelar]

Make sense to rename to Side Panel. I push fix to your branch. - remove modal rendering from VirtualPage - add test that check for Modal inside VP I saw there is an issue with Column Filter. I believe it has to do with data validation since DBAL is in place. Not sure where to look for Got to go now.

…

On Tue, Oct 5, 2021 at 4:21 PM Michael Voříšek ***@***.***> wrote: I will check. Should I push fix to this branch? Yes, small almost typo fix. Also, I wonder about the Right Panel name. What about Side Panel name instead? I belive it can be easily configured to be on the left side. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1670 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ2GPTF25LWQVIHHQKGIVLUFNM27ANCNFSM5FLZE26A> .

-- Alain Belair

[mvorisek]

Tests are passing, let's merge this fix. If there is any DBAL issue, please let me know and I can fix quickly.

[ibelar]

LGTM