Form Improvements #165
Merged
Form Improvements #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Date, Time and DateTime support Added hasOne() reference support.
…i into feature/form-improvements-hasmany
This was referenced May 20, 2017
DarkSide666
approved these changes
May 23, 2017
| @@ -17,11 +17,12 @@ | |||
| */ | |||
| class UI extends \atk4\data\Persistence | |||
| { | |||
| public $date_format = 'd/m/Y'; | |||
| public $date_format = 'M d, Y'; | |||
There was a problem hiding this comment.
how is this format better that d/m/Y ?
There was a problem hiding this comment.
it's not confusing for Americans and is working with the calendar widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented various improvements for the form:
Currency
Now shows currency in a box, not as a text.
DatePicker
TimePicker
And ...drumroll... hasOne field now shows up as drop-down:
Knows visual glitches:
Functionally all works well.