-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Virtual Page Action Executor #1649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked only the URL building, which seems ok now
@@ -103,6 +103,7 @@ protected function init(): void | |||
|
|||
if ($this->paginator !== false) { | |||
$this->addPaginator(); | |||
$this->stickyGet($this->paginator->name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if removed, does Behat testing fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no behat test for Card deck with either VpExecutor or new PanelExecutor. This is because the default executor register in ExecutorFactory is ModalExecutor. I can added tests but we need a way to be able to switch executor types dynamically. Any idea? Should we switch base on GET argument in init-app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant if sticky args in Card Deck are tested.
with either VpExecutor or new PanelExecutor...
I belive this does not need extra cross testing
Modal executors can be problematic sometimes on Mobile devices. This PR will added options to use a VirtualPage Executor instead which is more mobile-friendly.
In order to change executor type, simply register the new class for Model\UserAction
Executor preview:
Executor in arguments step:
Executor in fields step:
Executor in preview step: