Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute Behat Context #1628

Merged
merged 2 commits into from
May 11, 2021
Merged

Distribute Behat Context #1628

merged 2 commits into from
May 11, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 30, 2021 •
edited
Loading

should be helpful for atk4/login#73

later, we may want to split between distributed/stable api and internal context

@mvorisek mvorisek force-pushed the publish_behat_context branch 2 times, most recently from 4507c6e to dda2cd3 Compare May 2, 2021 14:20
@mvorisek mvorisek requested a review from ibelar May 2, 2021 14:27
@mvorisek mvorisek marked this pull request as draft May 3, 2021 09:02
mvorisek
mvorisek commented May 4, 2021
View reviewed changes
phpunit-mssql.xml.dist Outdated
@@ -28,6 +28,9 @@
<include>
<directory suffix=".php">src</directory>
</include>
<exclude>
Copy link
Member Author

@mvorisek mvorisek May 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed thanks to:

@mvorisek mvorisek force-pushed the publish_behat_context branch 2 times, most recently from e7b8a04 to c3a6559 Compare May 5, 2021 20:13
@mvorisek mvorisek force-pushed the publish_behat_context branch 2 times, most recently from 4e620b1 to cd7fe16 Compare May 11, 2021 10:55
@mvorisek mvorisek force-pushed the publish_behat_context branch from de3c660 to 61d0144 Compare May 11, 2021 13:29
@mvorisek mvorisek marked this pull request as ready for review May 11, 2021 13:38
@mvorisek mvorisek force-pushed the publish_behat_context branch from 61d0144 to 2c09f86 Compare May 11, 2021 13:39
@mvorisek mvorisek force-pushed the publish_behat_context branch from 1ac3168 to d6f677d Compare May 11, 2021 13:41
@mvorisek mvorisek merged commit 3decddd into develop May 11, 2021
@mvorisek mvorisek deleted the publish_behat_context branch May 11, 2021 13:44
@mvorisek mvorisek mentioned this pull request May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

@abbadon1334 abbadon1334 Awaiting requested review from abbadon1334

@ibelar ibelar Awaiting requested review from ibelar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @georgehristov