Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace call_user_func() calls as much as possible #1625

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 28, 2021

call_user_func() calls cannot be fully removed as long as property defaults should be supported - they are php-src constant expressions and they currently do not support Closures, not even first class callables.

@mvorisek mvorisek marked this pull request as draft April 28, 2021 08:11
@mvorisek mvorisek changed the title Fix PHPStan Do not use call_user_func Apr 29, 2021
@mvorisek mvorisek changed the title Do not use call_user_func Do not use call_user_func, support only Closure Apr 29, 2021
@mvorisek mvorisek force-pushed the fixstan branch 2 times, most recently from 168f38e to 550f526 Compare October 4, 2021 10:57
@mvorisek mvorisek force-pushed the fixstan branch 3 times, most recently from 8b77ca9 to 9146980 Compare October 10, 2021 21:32
@mvorisek mvorisek force-pushed the fixstan branch 3 times, most recently from ea344b1 to ede45ce Compare September 5, 2023 10:59
@mvorisek mvorisek marked this pull request as ready for review September 6, 2023 11:00
@mvorisek mvorisek changed the title Do not use call_user_func, support only Closure Replace call_user_func() as much as possible Sep 6, 2023
@mvorisek mvorisek changed the title Replace call_user_func() as much as possible Replace call_user_func() calls as much as possible Sep 6, 2023
@mvorisek mvorisek merged commit ae5cd3b into develop Sep 6, 2023
@mvorisek mvorisek deleted the fixstan branch September 6, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant