Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Property access for Modal Executor #1565

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Dec 7, 2020

Allow private property access.
Useful when a special form is needed in Modal Executor.

  • When model action uses Arguments you can safely return using $this->getStep() when the customs form is for field step only;
  • Get previous step data access using getActionData($step)

- Allow private property access.
Usefull when creating special form in Modal Executor.
@ibelar ibelar changed the title [fix] Better property access for Modal Executor [fix] Property access for Modal Executor Dec 7, 2020
@PhilippGrashoff
Copy link
Collaborator

Talking about private, wdyt about #1537? I think putting a lot of private in our code makes it less extendable and customizable. IMO private should only be used over protected when there is a very good reason for it.

@ibelar ibelar added the RTM label Dec 7, 2020
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkSide666 DarkSide666 merged commit fbf52d2 into develop Dec 9, 2020
@DarkSide666 DarkSide666 deleted the fix/modalexecutor-property-access branch December 9, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants