Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requiring atk4/data is enough #1557

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Requiring atk4/data is enough #1557

merged 4 commits into from
Dec 4, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 4, 2020

json ext is always available since PHP 8.0

@DarkSide666 DarkSide666 self-requested a review December 4, 2020 10:13
DarkSide666
DarkSide666 approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change as such is OK, but tests fail because new PHPUnit 9.5 doesn't have getAnnotations() method anymore.

@mvorisek mvorisek closed this Dec 4, 2020
@mvorisek mvorisek reopened this Dec 4, 2020
@mvorisek mvorisek changed the title Requiring atk4/data is enought Requiring atk4/data is enough Dec 4, 2020
@mvorisek mvorisek closed this Dec 4, 2020
@mvorisek mvorisek reopened this Dec 4, 2020
@mvorisek mvorisek merged commit df60a7b into develop Dec 4, 2020
@mvorisek mvorisek deleted the mvorisek-no-core-req branch December 4, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666