Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debouce for Behat testing (fake jQuery.active) #1524

Merged
merged 13 commits into from
Jul 12, 2021
Merged

Fix debouce for Behat testing (fake jQuery.active) #1524

merged 13 commits into from
Jul 12, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 29, 2020 •
edited
Loading

No description provided.

@mvorisek mvorisek requested a review from ibelar October 29, 2020 19:26
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch 2 times, most recently from 12cdd99 to 968a9f8 Compare October 30, 2020 09:16
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch 3 times, most recently from 062c3b2 to e825df7 Compare May 12, 2021 21:01
@mvorisek mvorisek changed the title Remove manual wait "for loading to start" from Behat Fix debounce timeout decrease, remove manual wait from Behat May 13, 2021
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch 4 times, most recently from 307906e to efc6ded Compare May 13, 2021 20:44
@mvorisek mvorisek changed the title Fix debounce timeout decrease, remove manual wait from Behat Allow debounce timeout change when active, remove manual wait from Behat May 13, 2021
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch from 1530915 to 2142058 Compare May 13, 2021 22:05
@mvorisek mvorisek changed the title Allow debounce timeout change when active, remove manual wait from Behat Allow debounce timeout change when active May 13, 2021
@mvorisek mvorisek marked this pull request as ready for review May 13, 2021 22:05
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch 7 times, most recently from 6d1de31 to c10a3a5 Compare May 13, 2021 23:00
@mvorisek mvorisek changed the title Allow debounce timeout change when active Allow debounce timeout override/change when active May 13, 2021
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch 3 times, most recently from c25ece9 to 42ca9bd Compare May 13, 2021 23:49
ibelar
ibelar reviewed May 14, 2021
View reviewed changes
js/src/atk-utils.js Outdated Show resolved Hide resolved
ibelar
ibelar reviewed May 14, 2021
View reviewed changes
js/src/atk-utils.js Outdated Show resolved Hide resolved
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch from 67db1c4 to 25461db Compare May 15, 2021 20:36
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch from deca61e to fbfe51b Compare May 15, 2021 20:54
@mvorisek mvorisek requested a review from ibelar May 15, 2021 20:58
@mvorisek mvorisek added RTM and removed RTM labels May 15, 2021
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch from c1a9757 to 92b2213 Compare May 15, 2021 21:33
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch from 92b2213 to 4ed4f1e Compare May 15, 2021 21:51
@mvorisek mvorisek added the RTM label May 26, 2021
This was referenced May 26, 2021
Closed
Closed
ibelar
ibelar approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibelar ibelar merged commit 11fe623 into develop Jul 12, 2021
@ibelar ibelar deleted the remove_manual_wait_from_behat branch July 12, 2021 16:12
@mvorisek mvorisek mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibelar ibelar ibelar approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

@georgehristov georgehristov Awaiting requested review from georgehristov

Assignees
No one assigned
Labels
Consistency RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @ibelar