Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UA execute exception should not be handled explicitly #1889

Closed
mvorisek opened this issue Oct 5, 2022 · 0 comments · Fixed by #2062
Closed

UA execute exception should not be handled explicitly #1889

mvorisek opened this issue Oct 5, 2022 · 0 comments · Fixed by #2062

Comments

@mvorisek
Copy link
Member

mvorisek commented Oct 5, 2022 •
edited
Loading

Currently StepExecutorTrait trait does handle an exceptions except ValidationException.

This is not for form field error handling, it is historical, see related #896 (comment).

There should be no intermediate custom exception handling.

I do not know any demo to reproduce, code for Behat testing must be probably written newly.

code:

ui/src/UserAction/StepExecutorTrait.php

Line 458 in 4844118

} catch (\Throwable $e) {

@mvorisek mvorisek mentioned this issue Jun 2, 2023
Merged
@mvorisek mvorisek changed the title UA execute exception must not be handled UA execute exception should not be handled explicitly Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove StepExecutorTrait::jsStepSubmit exception handling atk4/ui
1 participant
@mvorisek