Do not handle exception in UserAction ModalExecutor (#2008)

atk4 · Feb 24, 2023 · 4844118 · 4844118
1 parent a4d004f
commit 4844118
Showing 1 changed file with 13 additions and 33 deletions.
diff --git a/src/UserAction/StepExecutorTrait.php b/src/UserAction/StepExecutorTrait.php
@@ -110,27 +110,23 @@ protected function setFormField(Form $form, array $fields, string $step): Form
     protected function runSteps(): void
     {
         $this->loader->set(function (Loader $p) {
-            try {
-                switch ($this->step) {
-                    case 'args':
-                        $this->doArgs($p);
+            switch ($this->step) {
+                case 'args':
+                    $this->doArgs($p);
 
-                        break;
-                    case 'fields':
-                        $this->doFields($p);
+                    break;
+                case 'fields':
+                    $this->doFields($p);
 
-                        break;
-                    case 'preview':
-                        $this->doPreview($p);
+                    break;
+                case 'preview':
+                    $this->doPreview($p);
 
-                        break;
-                    case 'final':
-                        $this->doFinal($p);
+                    break;
+                case 'final':
+                    $this->doFinal($p);
 
-                        break;
-                }
-            } catch (\Exception $e) {
-                $this->handleException($e, $p, $this->step);
+                    break;
             }
         });
     }
@@ -515,20 +511,4 @@ protected function getActionArgs(array $data): array
 
         return $args;
     }
-
-    protected function handleException(\Throwable $exception, View $view, string $step): void
-    {
-        $msg = Message::addTo($view, ['Error:', 'type' => 'error']);
-        $msg->text->addHtml($this->getApp()->renderExceptionHtml($exception));
-        $view->js(true, $this->nextStepBtn->js()->addClass('disabled'));
-        if (!$this->isFirstStep($step)) {
-            $this->jsSetPrevHandler($view, $step);
-        }
-        if ($this->isLastStep($step)) {
-            $view->js(true, $this->execActionBtn->js()->addClass('disabled'));
-        }
-        if ($step === 'final') {
-            $this->jsSetPrevHandler($view, $this->steps[count($this->steps) - 1]);
-        }
-    }
 }