Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested form error reporting is broken #1817

Closed
mvorisek opened this issue Aug 20, 2022 · 0 comments · Fixed by #1888
Closed

Nested form error reporting is broken #1817

mvorisek opened this issue Aug 20, 2022 · 0 comments · Fixed by #1888
Labels

Comments

@mvorisek
Copy link
Member

mvorisek commented Aug 20, 2022

Steps to reproduce:

  1. open /demos/form-control/lookup.php
  2. in Lookup countries section (1st section after the first lookup field) click Save
  3. when submit atk4/data generates Must not be null validation exception, but this exception is currently caught by

    ui/src/Form.php

    Line 263 in 393dfc5

    } catch (\Atk4\Data\ValidationException $e) {
    and the generated JS that should set the error message below the field is broken

Currently no validation exception message is shown and Save does "nothing visible to the user".

Expected result:

image

In console I see:

image

maybe related

I am marking this issue as MAJOR as this issue might affect/hide all validation exceptions in (only nested?) forms and app user has no feedback why Save does not work.

The fix must cover this with Behat test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant