Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while loading external files on HTTPS #147

Closed
romaninsh opened this issue Apr 27, 2017 · 6 comments
Closed

Error while loading external files on HTTPS #147

romaninsh opened this issue Apr 27, 2017 · 6 comments
Assignees

Comments

@romaninsh
Copy link
Member

Looks like centered layout does not work when installed on HTTPS.

Layout requires file "css" from HTTP site

    <link rel="stylesheet" type="text/css" href="http://semantic-ui.com/dist/semantic.css">

screen shot 2017-04-27 at 10 29 59

@romaninsh
Copy link
Member Author

Temporary workaround - "use http://" instead of "https://"

@DarkSide666
Copy link
Member

Can you try setting it this way?
href="//semantic-ui.com/dist/semantic.css"

without protocol. It should work and automatically pick correct protocol.

@romaninsh
Copy link
Member Author

i thought we switched to CDN.. weird.

romaninsh added a commit that referenced this issue Apr 28, 2017
fix dependencies to use proper CDN /https for #147
@romaninsh
Copy link
Member Author

The issue is still there, because jslib is loaded from ui.agiletoolkit.org. We should modify our build so that it uploads complied JS file somewhere.

@romaninsh romaninsh added the JS label Apr 29, 2017
@DarkSide666 DarkSide666 changed the title Centered layout on HTTPS Error while loading external files on HTTPS Apr 29, 2017
@mvorisek
Copy link
Member

Is this issue still valid in 2020?

@DarkSide666
Copy link
Member

I think no because now we use CDN with https:

    public $cdn = [
        'atk'              => 'https://cdn.jsdelivr.net/gh/atk4/[email protected]/public',
        'jquery'           => 'https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1',
        'serialize-object' => 'https://cdnjs.cloudflare.com/ajax/libs/jquery-serialize-object/2.5.0',
        'semantic-ui'      => 'https://cdn.jsdelivr.net/npm/[email protected]/dist',
    ];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants