WIP fix remaining phpstan errors

atk4 · Dec 19, 2020 · dd2c346 · dd2c346
1 parent 8107624
commit dd2c346
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/demos/collection/multitable.php b/demos/collection/multitable.php
@@ -87,6 +87,7 @@ public function setModel(\Atk4\Data\Model $model, $route = [])
 
 \Atk4\Ui\Button::addTo($app, ['Re-Import From Filesystem', 'top attached'])->on('click', new \Atk4\Ui\JsModal('Now importing ... ', $vp));
 
+// @phpstan-ignore-next-line
 $finderClass::addTo($app, ['bottom attached'])
     ->addClass('top attached segment')
     ->setModel($model->setLimit(5), ['SubFolder']);
diff --git a/src/Form/Control/DropdownCascade.php b/src/Form/Control/DropdownCascade.php
@@ -47,7 +47,7 @@ protected function init(): void
             throw new Exception('cascadeFrom property should be an instance of ' . Form\Control::class);
         }
 
-        $this->cascadeControlValue = $_POST[$this->cascadeControl->name] ?? $this->cascadeControl->field->get('value');
+        $this->cascadeControlValue = $_POST[$this->cascadeControl->name] ?? $this->cascadeControl->field->get();
 
         $this->model = $this->cascadeControl->model ? $this->cascadeControl->model->ref($this->reference) : null;
 

diff --git a/src/JsCallback.php b/src/JsCallback.php
@@ -146,7 +146,7 @@ public function terminateAjax($ajaxec, $msg = null, $success = true)
      * Provided with a $response from callbacks convert it into a JavaScript code.
      *
      * @param array|JsExpressionable $response response from callbacks,
-     * @param string                 $chain    JavaScript string
+     * @param JsExpressionable       $chain
      */
     public function getAjaxec($response, $chain = null): string
     {

diff --git a/tools/get-assets.php b/tools/get-assets.php
@@ -18,6 +18,8 @@ public function requireJs($path, $isAsync = false, $isDefer = false)
         } else {
             echo "  failed\n";
         }
+
+        return $this;
     }
 
     public function requireCss($path)