Add actionshould respect enabled/disabled switch (#898)

atk4 · Jan 28, 2020 · d7a6446 · d7a6446
1 parent 678a301
commit d7a6446
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/CRUD.php b/src/CRUD.php
@@ -119,11 +119,18 @@ public function setModel(\atk4\data\Model $m, $fields = null): \atk4\data\Model
 
         if ($this->menu) {
             foreach ($this->_getModelActions(Generic::NO_RECORDS) as $k => $action) {
-                $action->ui['executor'] = $this->initActionExecutor($action);
-                $this->menuItems[$k]['item'] = $this->menu->addItem([$action->getDescription(), 'icon' => 'plus']);
-                $this->menuItems[$k]['action'] = $action;
+                if ($action->enabled) {
+                    $action->ui['executor'] = $this->initActionExecutor($action);
+                    $this->menuItems[$k]['item'] = $this->menu->addItem([$action->getDescription(), 'icon' => 'plus']);
+                    $this->menuItems[$k]['action'] = $action;
+                }
             }
             $this->setItemsAction();
+
+            // if no menuItems at all, then remove menu element
+            if (!$this->menuItems) {
+                $this->menu->destroy();
+            }
         }
 
         return $this->model;