fix phpstan

phpstan.neon.dist

@@ -16,6 +16,16 @@ parameters:
         - '~^Only booleans are allowed in .+, .+ given( on the (left|right) side)?\.~'
         - '~^Variable (static )?(property access|method call) on .+\.~'
 
+        # remove once PHPUnit 9.x support is removed
+        -
+            path: 'tests/DemosTest.php'
+            message: '~^Access to constant (STATUS_PASSED|STATUS_INCOMPLETE|STATUS_SKIPPED) on an unknown class PHPUnit\\Runner\\BaseTestRunner\.$~'
+            count: 3
+        -
+            path: 'src/Phpunit/DemosTest.php'
+            message: '~^Call to an undefined method Atk4\\Ui\\Tests\\DemosTest::(getName|getStatus)\(\)\.$~'
+            count: 4
+
         # TODO these rules are generated, this ignores should be fixed in the code
         # for level = 2
         -

src/Behat/CoverageUtil.php

@@ -36,16 +36,16 @@ public static function startFromPhpunitConfig(string $phpunitConfigDir): void
 
         $phpunitCoverageConfig = simplexml_load_file($phpunitConfigDir . '/phpunit.xml.dist')->coverage;
         foreach ($phpunitCoverageConfig->include->directory ?? [] as $path) {
-            $filter->includeDirectory($phpunitConfigDir . '/' . $path);
+            $filter->includeDirectory($phpunitConfigDir . '/' . $path); // @phpstan-ignore-line
         }
         foreach ($phpunitCoverageConfig->include->file ?? [] as $path) {
             $filter->includeFile($phpunitConfigDir . '/' . $path);
         }
         foreach ($phpunitCoverageConfig->exclude->directory ?? [] as $path) {
-            $filter->excludeDirectory($phpunitConfigDir . '/' . $path);
+            $filter->excludeDirectory($phpunitConfigDir . '/' . $path); // @phpstan-ignore-line
         }
         foreach ($phpunitCoverageConfig->exclude->file ?? [] as $path) {
-            $filter->excludeFile($phpunitConfigDir . '/' . $path);
+            $filter->excludeFile($phpunitConfigDir . '/' . $path); // @phpstan-ignore-line
         }
 
         static::start($filter);

tests/DemosTest.php

@@ -14,6 +14,7 @@
 use Atk4\Ui\Layout;
 use GuzzleHttp\Client;
 use GuzzleHttp\Psr7\Request;
+use PHPUnit\Runner\BaseTestRunner;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;
 
@@ -31,6 +32,7 @@ class DemosTest extends TestCase
 
     private static ?Persistence $_db = null;
 
+    /** @var array<string, int> */
     private static array $_failedParentTests = [];
 
     public static function setUpBeforeClass(): void
@@ -74,13 +76,9 @@ protected function setUp(): void
 
     protected function _onNotSuccessfulTest(\Throwable $t): void
     {
-        if (!in_array($this->getStatus(), [
-            \PHPUnit\Runner\BaseTestRunner::STATUS_PASSED,
-            \PHPUnit\Runner\BaseTestRunner::STATUS_SKIPPED,
-            \PHPUnit\Runner\BaseTestRunner::STATUS_INCOMPLETE,
-        ], true)) {
-            if (!isset(self::$_failedParentTests[$this->getName()])) {
-                self::$_failedParentTests[$this->getName()] = $this->getStatus();
+        if (self::isPhpunit9x() ? !in_array($this->getStatus(), [BaseTestRunner::STATUS_PASSED, BaseTestRunner::STATUS_SKIPPED, BaseTestRunner::STATUS_INCOMPLETE], true) : !$this->status()->isPassed() && !$this->status()->isSkipped() && !$this->status()->isIncomplete()) {
+            if (!isset(self::$_failedParentTests[self::isPhpunit9x() ? $this->getName() : $this->nameWithDataSet()])) {
+                self::$_failedParentTests[self::isPhpunit9x() ? $this->getName() : $this->nameWithDataSet()] = self::isPhpunit9x() ? $this->getStatus() : $this->status()->asInt();
             } else {
                 self::markTestIncomplete('Test failed, but non-HTTP test failed too, fix it first');
             }