optimize Multiline save if a lot of records are unchanged

atk4 · Oct 3, 2023 · 619df7f · 619df7f
1 parent 351d6bf
commit 619df7f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/Form/Control/Multiline.php b/src/Form/Control/Multiline.php
@@ -340,7 +340,9 @@ public function saveRows(): self
         $currentIds = array_column($model->export(), $model->idField);
 
         foreach ($this->rowData as $row) {
-            $entity = $row[$model->idField] !== null ? $model->load($row[$model->idField]) : $model->createEntity();
+            $entity = $row[$model->idField] !== null
+                ? $model->load($row[$model->idField])
+                : $model->createEntity();
             foreach ($row as $fieldName => $value) {
                 if ($fieldName === '__atkml') {
                     continue;
@@ -350,9 +352,12 @@ public function saveRows(): self
                     $entity->set($fieldName, $value);
                 }
             }
-            $id = $entity->save()->getId();
 
-            $k = array_search($id, $currentIds, true);
+            if (!$entity->isLoaded() || $entity->getDirtyRef() !== []) {
+                $entity->save();
+            }
+
+            $k = array_search($entity->getId(), $currentIds, true);
             if ($k !== false) {
                 unset($currentIds[$k]);
             }