Improve memory leak testing

atk4 · Jun 22, 2021 · 00a3ce5 · 00a3ce5
1 parent ad5c0bb
commit 00a3ce5
Show file tree

Hide file tree

Showing 25 changed files with 47 additions and 46 deletions.
diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml
@@ -102,7 +102,7 @@ jobs:
     services:
       mysql:
         image: mysql:8
-        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5 -e MYSQL_ROOT_PASSWORD=atk4_pass -e MYSQL_USER=atk4_test -e MYSQL_PASSWORD=atk4_pass -e MYSQL_DATABASE=atk4_test__data --entrypoint sh mysql:8 -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password"
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5 -e MYSQL_ROOT_PASSWORD=atk4_pass_root -e MYSQL_USER=atk4_test -e MYSQL_PASSWORD=atk4_pass -e MYSQL_DATABASE=atk4_test__data --entrypoint sh mysql:8 -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password"
       mssql:
         image: mcr.microsoft.com/mssql/server
         env:
@@ -138,11 +138,12 @@ jobs:
           if [ "${{ matrix.type }}" != "StaticAnalysis" ]; then composer remove --no-interaction --no-update phpstan/phpstan 'behat/*' --dev ; fi
           composer update --ansi --prefer-dist --no-interaction --no-progress --optimize-autoloader
           if [ "${{ matrix.type }}" == "Phpunit Lowest" ]; then composer update  --ansi --prefer-dist --prefer-lowest --prefer-stable --no-interaction --no-progress --optimize-autoloader ; fi
-          if [ "${{ matrix.type }}" == "Phpunit Burn" ]; then sed -i 's/ *public function runBare(): void/public function runBare(): void { gc_collect_cycles(); $mem0 = memory_get_usage(); for ($i = 0; $i < '"$(if [ \"$GITHUB_EVENT_NAME\" == \"schedule\" ]; then echo 5; else echo 5; fi)"'; ++$i) { $this->_runBare(); if ($i === 0) { gc_collect_cycles(); $mem1 = memory_get_usage(); } } gc_collect_cycles(); $mem2 = memory_get_usage(); if ($mem2 - 3072 * 1024 > $mem0 || $mem2 - 1536 * 1024 > $mem1) { $this->onNotSuccessfulTest(new AssertionFailedError("Memory leak detected! (" . round($mem0 \/ (1024 * 1024), 3) . " + " . round(($mem1 - $mem0) \/ (1024 * 1024), 3) . " + " . round(($mem2 - $mem1) \/ (1024 * 1024), 3) . " MB, " . $i . " iterations)")); } } private function _runBare(): void/' vendor/phpunit/phpunit/src/Framework/TestCase.php && cat vendor/phpunit/phpunit/src/Framework/TestCase.php | grep '_runBare(' ; fi
+          if [ "${{ matrix.type }}" == "Phpunit Burn" ]; then sed -i 's/ *public function runBare(): void/public function runBare(): void { gc_collect_cycles(); gc_collect_cycles(); $mem0 = memory_get_usage(); for ($i = 0; $i < '"$(if [ \"$GITHUB_EVENT_NAME\" == \"schedule\" ]; then echo 20; else echo 20; fi)"'; ++$i) { $this->_runBare(); gc_collect_cycles(); gc_collect_cycles(); if ($i === 0) { $mem1 = memory_get_usage(); } } $mem2 = memory_get_usage(); if ($mem2 - 3072 * 1024 > $mem0 || $mem2 - 1024 * 1024 > $mem1) { $this->onNotSuccessfulTest(new AssertionFailedError("Memory leak detected! (" . round($mem0 \/ (1024 * 1024), 3) . " MB + " . round(($mem1 - $mem0) \/ (1024 * 1024), 3) . " MB + " . round(($mem2 - $mem1) \/ 1024, 3) . " KB, " . $i . " iterations)")); } } private function _runBare(): void/' vendor/phpunit/phpunit/src/Framework/TestCase.php && cat vendor/phpunit/phpunit/src/Framework/TestCase.php | grep '_runBare(' ; fi
 
       - name: Init
         run: |
           mkdir -p build/logs
+          php -r '(new PDO("mysql:host=mysql", "root", "atk4_pass_root"))->exec("ALTER USER '"'"'atk4_test'"'"'@'"'"'%'"'"' WITH MAX_USER_CONNECTIONS 5");'
           php demos/_demo-data/create-sqlite-db.php
 
       - name: "Run tests: SQLite (only for Phpunit)"

diff --git a/phpunit-mssql.xml.dist b/phpunit-mssql.xml.dist
@@ -1,4 +1,4 @@
-<phpunit bootstrap="vendor/autoload.php" printerClass="Atk4\Core\AtkPhpunit\ResultPrinter" colors="true">
+<phpunit bootstrap="vendor/autoload.php" printerClass="Atk4\Core\Phpunit\ResultPrinter" colors="true">
     <php>
         <var name="DB_DSN" value="sqlsrv:Server=mssql;Database=master" />
         <var name="DB_USER" value="sa" />

diff --git a/phpunit-mysql.xml.dist b/phpunit-mysql.xml.dist
@@ -1,4 +1,4 @@
-<phpunit bootstrap="vendor/autoload.php" printerClass="Atk4\Core\AtkPhpunit\ResultPrinter" colors="true">
+<phpunit bootstrap="vendor/autoload.php" printerClass="Atk4\Core\Phpunit\ResultPrinter" colors="true">
     <php>
         <var name="DB_DSN" value="mysql:dbname=atk4_test__data;host=mysql" />
         <var name="DB_USER" value="atk4_test" />

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,4 +1,4 @@
-<phpunit bootstrap="vendor/autoload.php" printerClass="Atk4\Core\AtkPhpunit\ResultPrinter" colors="true">
+<phpunit bootstrap="vendor/autoload.php" printerClass="Atk4\Core\Phpunit\ResultPrinter" colors="true">
     <php>
         <var name="DB_DSN" value="sqlite::memory:" />
         <var name="DB_USER" value="" />

diff --git a/tests/AppTest.php b/tests/AppTest.php
@@ -4,11 +4,11 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\App;
 use Atk4\Ui\HtmlTemplate;
 
-class AppTest extends AtkPhpunit\TestCase
+class AppTest extends TestCase
 {
     protected function getApp()
     {

diff --git a/tests/ButtonTest.php b/tests/ButtonTest.php
@@ -4,10 +4,10 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\Button;
 
-class ButtonTest extends AtkPhpunit\TestCase
+class ButtonTest extends TestCase
 {
     /**
      * @doesNotPerformAssertions

diff --git a/tests/CallbackTest.php b/tests/CallbackTest.php
@@ -4,7 +4,7 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 
 class AppMock extends \Atk4\Ui\App
 {
@@ -24,7 +24,7 @@ protected function outputResponse(string $data, array $headers): void
     }
 }
 
-class CallbackTest extends AtkPhpunit\TestCase
+class CallbackTest extends TestCase
 {
     /** @var string */
     private $htmlDoctypeRegex = '~^<!DOCTYPE~';

diff --git a/tests/DemosTest.php b/tests/DemosTest.php
@@ -4,7 +4,7 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Data\Persistence;
 use Atk4\Ui\App;
 use GuzzleHttp\Client;
@@ -17,7 +17,7 @@
  *
  * Requests are emulated in the same process. It is fast, but some output or shutdown functionality can not be fully tested.
  */
-class DemosTest extends AtkPhpunit\TestCase
+class DemosTest extends TestCase
 {
     /** @const string */
     protected const ROOT_DIR = __DIR__ . '/..';

diff --git a/tests/ExecutorFactoryTest.php b/tests/ExecutorFactoryTest.php
@@ -4,7 +4,7 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Data\Model;
 use Atk4\Data\Persistence\Array_;
 use Atk4\Ui\App;
@@ -36,7 +36,7 @@ protected function init(): void
     }
 }
 
-class ExecutorFactoryTest extends AtkPhpunit\TestCase
+class ExecutorFactoryTest extends TestCase
 {
     /** @var Model */
     public $model;

diff --git a/tests/ForFieldUiTest.php b/tests/ForFieldUiTest.php
@@ -4,7 +4,7 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Data\Model;
 use Atk4\Data\Persistence;
 
@@ -24,7 +24,7 @@ protected function init(): void
  * Test is designed to verify that field which is explicitly editable should appear and be editable
  * even if 'never_persist' is set to true.
  */
-class ForFieldUiTest extends AtkPhpunit\TestCase
+class ForFieldUiTest extends TestCase
 {
     /** @var Model */
     public $m;

diff --git a/tests/FormTest.php b/tests/FormTest.php
@@ -4,12 +4,12 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Data\Model;
 use Atk4\Ui\App;
 use Atk4\Ui\Form;
 
-class FormTest extends AtkPhpunit\TestCase
+class FormTest extends TestCase
 {
     /** @var Form */
     public $f;

diff --git a/tests/GridTest.php b/tests/GridTest.php
@@ -6,7 +6,7 @@
 
 use Atk4\Ui\Table;
 
-class GridTest extends \Atk4\Core\AtkPhpunit\TestCase
+class GridTest extends \Atk4\Core\Phpunit\TestCase
 {
     use Concerns\HandlesTable;
 

diff --git a/tests/HtmlTemplateTest.php b/tests/HtmlTemplateTest.php
@@ -4,12 +4,12 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\Exception;
 use Atk4\Ui\HtmlTemplate;
 use Atk4\Ui\HtmlTemplate\TagTree;
 
-class HtmlTemplateTest extends AtkPhpunit\TestCase
+class HtmlTemplateTest extends TestCase
 {
     protected function assertSameTemplate(string $expectedTemplateStr, HtmlTemplate $template): void
     {

diff --git a/tests/JsIntegrationTest.php b/tests/JsIntegrationTest.php
@@ -4,11 +4,11 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\Button;
 use Atk4\Ui\View;
 
-class JsIntegrationTest extends AtkPhpunit\TestCase
+class JsIntegrationTest extends TestCase
 {
     public function testIdIntegrity1(): void
     {

diff --git a/tests/JsTest.php b/tests/JsTest.php
@@ -4,13 +4,13 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\Jquery;
 use Atk4\Ui\JsChain;
 use Atk4\Ui\JsExpression;
 use Atk4\Ui\JsFunction;
 
-class JsTest extends AtkPhpunit\TestCase
+class JsTest extends TestCase
 {
     public function testBasicExpressions(): void
     {

diff --git a/tests/ListerTest.php b/tests/ListerTest.php
@@ -4,11 +4,11 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\Exception;
 use Atk4\Ui\HtmlTemplate;
 
-class ListerTest extends AtkPhpunit\TestCase
+class ListerTest extends TestCase
 {
     /**
      * @doesNotPerformAssertions

diff --git a/tests/LocaleTest.php b/tests/LocaleTest.php
@@ -4,11 +4,11 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\Exception;
 use Atk4\Ui\Locale;
 
-class LocaleTest extends AtkPhpunit\TestCase
+class LocaleTest extends TestCase
 {
     public function testException(): void
     {

diff --git a/tests/PaginatorTest.php b/tests/PaginatorTest.php
@@ -4,9 +4,9 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 
-class PaginatorTest extends AtkPhpunit\TestCase
+class PaginatorTest extends TestCase
 {
     public $p;
 

diff --git a/tests/PostTest.php b/tests/PostTest.php
@@ -4,10 +4,10 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Data\Model;
 
-class PostTest extends AtkPhpunit\TestCase
+class PostTest extends TestCase
 {
     /** @var Model */
     public $model;

diff --git a/tests/RenderTreeTest.php b/tests/RenderTreeTest.php
@@ -4,14 +4,14 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\View;
 
 /**
  * Multiple tests to ensure that adding views through various patterns initializes them
  * nicely still.
  */
-class RenderTreeTest extends AtkPhpunit\TestCase
+class RenderTreeTest extends TestCase
 {
     public function testBasic(): void
     {

diff --git a/tests/TableColumnColorRatingTest.php b/tests/TableColumnColorRatingTest.php
@@ -4,10 +4,10 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\Table;
 
-class TableColumnColorRatingTest extends AtkPhpunit\TestCase
+class TableColumnColorRatingTest extends TestCase
 {
     use Concerns\HandlesTable;
 

diff --git a/tests/TableColumnLinkTest.php b/tests/TableColumnLinkTest.php
@@ -4,10 +4,10 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 use Atk4\Ui\Table;
 
-class TableColumnLinkTest extends AtkPhpunit\TestCase
+class TableColumnLinkTest extends TestCase
 {
     use Concerns\HandlesTable;
 

diff --git a/tests/TableTest.php b/tests/TableTest.php
@@ -4,9 +4,9 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 
-class TableTest extends AtkPhpunit\TestCase
+class TableTest extends TestCase
 {
     /**
      * @doesNotPerformAssertions

diff --git a/tests/TagTest.php b/tests/TagTest.php
@@ -4,9 +4,9 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
+use Atk4\Core\Phpunit\TestCase;
 
-class TagTest extends AtkPhpunit\TestCase
+class TagTest extends TestCase
 {
     public function getApp()
     {

diff --git a/tests/ViewTest.php b/tests/ViewTest.php
@@ -4,10 +4,10 @@
 
 namespace Atk4\Ui\Tests;
 
-use Atk4\Core\AtkPhpunit;
 use Atk4\Core\Exception;
+use Atk4\Core\Phpunit\TestCase;
 
-class ViewTest extends AtkPhpunit\TestCase
+class ViewTest extends TestCase
 {
     /**
      * Test redering multiple times.