Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Model nesting #946

Merged
merged 17 commits into from
Jan 12, 2022
Merged

Add support for Model nesting #946

merged 17 commits into from
Jan 12, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 31, 2021

when saving, all inner models hooks are executed

no BC break

Array persistence support will be added in another PR - #961

@mvorisek mvorisek added the MAJOR label Dec 31, 2021
@mvorisek mvorisek force-pushed the model_in_model branch 4 times, most recently from 1c6fb95 to 9d64113 Compare December 31, 2021 12:02
@mvorisek mvorisek changed the base branch from develop to model_in_model_base December 31, 2021 13:02
@mvorisek mvorisek force-pushed the model_in_model_base branch from 9d64113 to 0012ac9 Compare December 31, 2021 17:21
@mvorisek mvorisek force-pushed the model_in_model branch 17 times, most recently from 999265f to 89d1883 Compare January 2, 2022 00:49
@mvorisek mvorisek force-pushed the model_in_model_base branch from 0012ac9 to 2a4cb1e Compare January 2, 2022 11:55
@mvorisek mvorisek force-pushed the model_in_model branch 4 times, most recently from 8d3c605 to f53ef21 Compare January 2, 2022 18:20
@mvorisek mvorisek force-pushed the model_in_model_base branch from 2a4cb1e to fe76395 Compare January 2, 2022 21:11
@mvorisek mvorisek force-pushed the model_in_model branch 4 times, most recently from 8684a3d to 0c70811 Compare January 11, 2022 23:19
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Model/Join.php Show resolved Hide resolved
@mvorisek mvorisek merged commit e91bf15 into develop Jan 12, 2022
@mvorisek mvorisek deleted the model_in_model branch January 12, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants