Improve Model::withPersistence #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Jul 26, 2020
|
|
||
| return $m; | ||
| $model->data = $this->data; |
There was a problem hiding this comment.
I think this method duplicates some other code.
Why is copying data prop better than ->set($model->get()) (some mention in the title?)
The code before it is a duplicate of asModel(), right?
There was a problem hiding this comment.
No. asModel and newInstance use the same persistence.
Why is copying data prop better than ->set($model->get()) (some mention in the title?)
I will remove this from the code comments as data is copied from the source model already.
What you expect from this method is a model clone with different persistence.
There was a problem hiding this comment.
Hmm, do your bests and lets merge this
mvorisek
approved these changes
Jul 26, 2020
|
|
||
| return $m; | ||
| $model->data = $this->data; |
There was a problem hiding this comment.
Hmm, do your bests and lets merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.