Fix DiContainerTrait::setDefault /w numeric key (#349)

.github/workflows/build-release.yml

@@ -14,7 +14,7 @@ jobs:
     container:
       image: ghcr.io/mvorisek/image-php:latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           ref: ${{ github.ref }}
 

.github/workflows/test-unit.yml

@@ -24,7 +24,7 @@ jobs:
             type: 'StaticAnalysis'
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Configure PHP
         run: |
@@ -84,7 +84,7 @@ jobs:
       LOG_COVERAGE: "${{ fromJSON('{true: \"1\", false: \"\"}')[matrix.php == '8.0' && matrix.type == 'Phpunit' && (github.event_name == 'pull_request' || (github.event_name == 'push' && (github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/master')))] }}"
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Configure PHP
         run: |

docs/config.rst

@@ -15,15 +15,15 @@ Configuration files can be of 4 types : php, php-inline, json, yaml.
 Loading can be done in this way :
 
     $object = new Object();
-    $object->readConfig('config.php','php');
+    $object->readConfig('config.php', 'php');
 
 After loading, configuration elements can be retrieved in this way :
 
-    $object->getConfig('element_key','if not defined use this as default');
+    $object->getConfig('element_key', 'if not defined use this as default');
 
 if you need an element that is declared inside an array you can use a special syntax :
 
-    $object->getConfig('level1_array/level2_array/element_key','if not defined use this as default');
+    $object->getConfig('level1_array/level2_array/element_key', 'if not defined use this as default');
 
 Element in config can be defined even manually :
 

docs/dynamicmethod.rst

@@ -10,7 +10,7 @@ Introduction
 Adds ability to add methods into objects dynamically. That's like a "trait"
 feature of a PHP, but implemented in run-time::
 
-    $object->addMethod('test', function($o, $args) { echo 'hello, '.$args[0]; });
+    $object->addMethod('test', function($o, $args) { echo 'hello, ' . $args[0]; });
     $object->test('world');
 
 Global Methods
@@ -21,7 +21,7 @@ implements :php:trait:`HookTrait` then executing $object->test() will also
 look for globally-registered method inside the application::
 
     $object->getApp()->addGlobalMethod('test', function($app, $o, $args) {
-        echo 'hello, '.$args[0];
+        echo 'hello, ' . $args[0];
     });
 
     $object->test('world');

docs/index.rst

@@ -152,7 +152,7 @@ Hook-based dynamic Methods
 dynamically.
 That's like a "trait" feature of a PHP, but implemented in run-time::
 
-    $object->addMethod('test', function($o, $args) { echo 'hello, '.$args[0]; } );
+    $object->addMethod('test', function($o, $args) { echo 'hello, ' . $args[0]; } );
     $object->test('world');
     // outputs: hello, world
 

docs/initializer.rst

@@ -33,7 +33,7 @@ Declare a object class in your framework::
         }
 
         function render() {
-            return '<input name="'.$this->name.'" value="'.$value.'"/>';
+            return '<input name="' . $this->name . '" value="' . $value . '"/>';
         }
     }
 

src/ConfigTrait.php

@@ -62,7 +62,7 @@ public function readConfig($files = ['config.php'], string $format = 'php')
 
                     break;
                 default:
-                    throw (new Exception('Unknown Format. Allowed formats: php, json, yml.'))
+                    throw (new Exception('Unknown Format. Allowed formats: php, json, yml'))
                         ->addMoreInfo('file', $file)
                         ->addMoreInfo('format', $format);
             }

src/DiContainerTrait.php

@@ -45,6 +45,10 @@ trait DiContainerTrait
     public function setDefaults(array $properties, bool $passively = false)
     {
         foreach ($properties as $key => $val) {
+            if (is_int($key)) {
+                $key = (string) $key;
+            }
+
             if (property_exists($this, $key)) {
                 if ($passively && $this->{$key} !== null) {
                     continue;

src/Factory.php

@@ -135,7 +135,7 @@ protected function _factory($seed, array $defaults = null): object
         }
 
         if ((!is_array($seed) && !is_object($seed))) {
-            throw new Exception('Use of non-array seed ($seed type = ' . gettype($seed) . ') is not supported.');
+            throw new Exception('Use of non-array seed ($seed type = ' . gettype($seed) . ') is not supported');
         }
 
         array_unshift($defaults, null); // insert argument 0

src/TraitUtil.php

@@ -28,7 +28,7 @@ public static function hasTrait($class, string $traitName): bool
         // prevent mass use for other than internal use then we can decide
         // if we want to keep support this or replace with pure interfaces
         if (!str_starts_with($traitName, 'Atk4\Core\\')) {
-            throw new Exception('Core::hasTrait is not indended for use with other than \Atk4\Core\* traits.');
+            throw new Exception('Core::hasTrait is not indended for use with other than \Atk4\Core\* traits');
         }
 
         if (!isset(self::$_hasTraitCache[$class][$traitName])) {

tests/DiContainerTraitTest.php

@@ -22,18 +22,18 @@ public function testFromSeed(): void
         StdSat2::fromSeed([StdSat::class]);
     }
 
-    public function testNoPropExNumeric(): void
+    public function testNoPropExStandard(): void
     {
-        $this->expectException(\Error::class);
+        $this->expectException(Exception::class);
         $m = new FactoryDiMock2();
-        $m->setDefaults([5 => 'qwerty']);
+        $m->setDefaults(['not_exist' => 'qwerty']);
     }
 
-    public function testNoPropExStandard(): void
+    public function testNoPropExNumeric(): void
     {
         $this->expectException(Exception::class);
         $m = new FactoryDiMock2();
-        $m->setDefaults(['not_exist' => 'qwerty']);
+        $m->setDefaults([5 => 'qwerty']);
     }
 
     public function testProperties(): void