Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directive name parsing during minification #4

Merged
merged 1 commit into from
May 21, 2019
Merged

Fix directive name parsing during minification #4

merged 1 commit into from
May 21, 2019

Conversation

atifaziz
Copy link
Owner

Fix for issue #3.

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #4 into master will decrease coverage by 1.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   98.18%   96.88%   -1.31%     
==========================================
  Files          11       11              
  Lines        1543     1027     -516     
==========================================
- Hits         1515      995     -520     
- Misses         28       32       +4
Impacted Files Coverage Δ
src/CSharpMinifier/Minifier.cs 100% <100%> (ø) ⬆️
src/CSharpMinifier/CSharpString.cs 91.75% <0%> (-3.76%) ⬇️
src/CSharpMinifier/Position.cs 82.35% <0%> (-0.99%) ⬇️
src/CSharpMinifier/JsonString.cs 96.42% <0%> (-0.55%) ⬇️
src/CSharpMinifier/Scanner.cs 99.76% <0%> (-0.09%) ⬇️
src/CSharpMinifier/SubstringPool.cs 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfb6ee...b2037f9. Read the comment docs.

@atifaziz atifaziz merged commit be79539 into master May 21, 2019
@atifaziz atifaziz deleted the fix-3 branch May 21, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant