Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: monthly updates for July'23 #134

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: monthly updates for July'23 #134

merged 1 commit into from
Jul 18, 2023

Conversation

yozachar
Copy link
Collaborator

  • migrate to pdm from poetry
  • update dependencies
  • improvises containerfile (drops dockerfile)
  • only python & pip are required in ci/cd
  • adds compose.yml
  • simplifies local & containerized development

@yozachar yozachar self-assigned this Jul 15, 2023
@yozachar yozachar added documentation Improvements or additions to documentation maintenance Maintenance Work dependencies Pull requests that update a dependency file Open for review PR is open for review labels Jul 15, 2023
@yozachar yozachar force-pushed the workshop branch 4 times, most recently from f9e413b to a500f75 Compare July 16, 2023 01:25
@yozachar
Copy link
Collaborator Author

Workflow failing: https://github.com/joe733/joe733/actions. Fix WIP.

@yozachar yozachar marked this pull request as draft July 16, 2023 01:37
@yozachar yozachar force-pushed the workshop branch 3 times, most recently from 0ce3454 to db52203 Compare July 17, 2023 02:58
@yozachar
chore: monthly updates for July'23
77ba5f6 
- migrate to `pdm` from `poetry`
- update dependencies
- improvises `dockerfile` (drops `containerfile`)
- only `python` & `pip` are required in ci/cd
- adds `compose.yml`
- simplifies local & containerized development
@yozachar
Copy link
Collaborator Author

yozachar commented Jul 17, 2023 •
edited
Loading

Takeaways:

  • GitHub Actions doesn't like messing with WORKDIR or USER. ref: https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions

  • Dockerfile's ENV allows only a single syntax for per command, i.e. if you do the following, it won't work:

    ENV    SOME_VAR_WITHOUT_DEFAULT \
       PATH=NEW_PATH:$PATH

    $PATH does not get updated.

  • And for some weird reason, only on GitHub Actions, python doesn't accept main.py script as a module, i.e. python -m /path/to/main fails.

@yozachar yozachar marked this pull request as ready for review July 17, 2023 03:14
@yozachar yozachar removed the Open for review PR is open for review label Jul 18, 2023
@yozachar yozachar merged commit cefd952 into athul:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yozachar yozachar

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation maintenance Maintenance Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yozachar