Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babashka support #17

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Babashka support #17

merged 6 commits into from
Oct 20, 2022

Conversation

athos
Copy link
Owner

@athos athos commented Oct 18, 2022

To support Babashka:

  • Use locking instead of ReentrantLock (as Babashka doesn't support it)
  • Determine if an object is a session by checking if it implements ILogStorage, rather than the ISession marker protocol (as Babashka at this moment doesn't support marker protocols on deftypes)

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 92.38% // Head: 92.38% // No change to project coverage 👍

Coverage data is based on head (71d78de) compared to base (ff159d3).
Patch coverage: 96.15% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files           7        7           
  Lines         394      394           
  Branches       17       17           
=======================================
  Hits          364      364           
  Misses         13       13           
  Partials       17       17           
Impacted Files Coverage Δ
src/postmortem/utils.cljc 71.42% <66.66%> (ø)
src/postmortem/core.cljc 86.66% <100.00%> (ø)
src/postmortem/instrument/clj.cljc 96.00% <100.00%> (ø)
src/postmortem/session.cljc 95.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@athos athos force-pushed the feature/babashka-support branch 4 times, most recently from 5547051 to 8b06e43 Compare October 19, 2022 14:34
@athos athos marked this pull request as ready for review October 19, 2022 14:37
@athos athos force-pushed the feature/babashka-support branch 2 times, most recently from dbc86df to 8d84417 Compare October 19, 2022 15:26
@athos athos force-pushed the feature/babashka-support branch from 8d84417 to 71d78de Compare October 20, 2022 04:44
@athos athos merged commit 675f00e into master Oct 20, 2022
@athos athos deleted the feature/babashka-support branch October 20, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant