Support Drone 0.5 #19
Conversation
The previous support for Drone 0.5 did not actually work. This was because the `drone-node` plugin was being instatniated regardless of node version which fails since it tries to parse the input JSON.
|
cc @athieriot |
|
Excellent thanks ! |
|
Build fails, not entirely sure what's happening there |
|
Fails on |
|
I think some of the mocking by nock might be failing |
|
Might be, be all the tests seem to pass:
https://beta.drone.io/athieriot/drone-artifactory/29/3
It even shows a good coverage...
|
|
Right so could we merge anyway then? It'd be great if this could be released as it blocks me with what I'm currently trying to do |
|
Sorry if it's rude but I need to ask: Did you try it on your Drone instance? (I might require a digital blood signature) |
|
This fix? No I didn't, but I debugged it and found that the error I saw was related to the invocation of |
|
Don't hesitate to come back with another PR if you're blocked again. |
|
Thanks, I guess there's a risk that it will not publish due to the tests failing however |
|
Yes that is indeed what happens. I'll have a look and see if I can't resolve that. |
|
Resolved in #20 |
The previous support for Drone 0.5 did not actually work. This
was because the
drone-nodeplugin was being instatniated regardlessof node version which fails since it tries to parse the input JSON.