Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): issue updating Mac App #777

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

sboesen
Copy link
Contributor

@sboesen sboesen commented Mar 8, 2021

This PR fixes just the package.json config to re-enable ZIP target on Mac builds, which should re-enable auto-update on Mac.

Fixes #749

Note: Issue #749 references an error popup, but was originally about auto update on Mac being broken, which this fixes.

#722 appears to reference that same error popup in #749, and is still not fixed.

@tangjeff0 tangjeff0 merged commit cf259a1 into athensresearch:master Mar 9, 2021
@sboesen
Copy link
Contributor Author

sboesen commented Mar 9, 2021

This issue should be reopened, I suspect auto-update now works for M1 macs but after testing from Athens Beta 52 on an Intel mac it downloads the ARM64 update of Beta 53 by default, breaking the current Athens installation.

Current workaround for Intel Macs is to click "Cancel" during update prompt and wait for fix.

Screen Shot 2021-03-09 at 1 53 58 PM

I suspect this may be a bug/feature gap in electron-updater after reviewing the relevant code introduced in the most recent electron-builder release 22.10.5 in an attempt to fix auto-update for M1 macs (code here, relevant PR describing the issue were trying to fix) and I'm still looking to see if there's something we can do to avoid this issue or if we need to roll back electron-builder to 22.10.4 (which doesn't include these filters).

Will be testing on my own S3 bucket to see if I can get this working, should have an update later today or tomorrow morning. We'll definitely want to make sure that this works on M1 macs too after the change (and doesn't download the Intel version), something I'm unfortunately still limited in testing.

@tangjeff0
Copy link
Collaborator

tangjeff0 commented Mar 10, 2021

@sboesen created a new issue for this #793. Someone encountered the issue with x64 -> arm. My M1 was able to auto-update, so that was tested. By the way, you can create a local AWS server with Minio. See docs here: https://github.com/athensresearch/athens/pull/750/files. I recommend using yarn update to easily create a new tagged release, which is how electron determines a new update is available.

korlaism pushed a commit to korlaism/athens that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(electron): "Cannot read property '0' of null"
2 participants