-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(electron): update from 9 to 11 #707
Conversation
Seeing if downloading and installing Xcode will make a difference on my M1 |
I think the version of |
@sboesen hadn't tried updating builder yet! If someone with an m1 manages to build, I'll split the bounty between you two. If I get to it, I'll just give the bounty to you. |
Able to build now! @sboesen |
1f7086e
to
6a1afa8
Compare
6a1afa8
to
71491ad
Compare
@tangjeff0 Great to hear that fix worked! |
Do you want to submit to get the bounty for https://gitcoin.co/issue/athensresearch/athens/708/100024940? |
Thank you - I just marked work as submitted with your commit as a reference. Please let me know if I need to change anything! |
Think that's it. Gonna make sure it builds and deploys at https://github.com/athensresearch/athens/runs/2037107204?check_suite_focus=true then will approve. |
Looks good! |
Fantastic, thanks so much! |
darwin-arm64
build which is for M1 Mac.resources
Having some trouble here. Keep on getting
Unrecognized symbol error
seeming to stem from a python file. Tried thepatch-package
approach and error still exists.To clarify, the problem is with
electron-builder
, notelectron
. There are a few other cross-platform builders for electron that do seem to more up to date.