-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support audio files #2224
base: main
Are you sure you want to change the base?
Support audio files #2224
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deployment failed with the following error:
|
@@ -265,6 +265,12 @@ | |||
:borderRadius "md" | |||
:alt alt | |||
:src url}]) | |||
:url-audio (fn [{url :src alt :alt}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working, dunno how if chakra ui supports audio
@@ -70,6 +71,7 @@ | |||
:id base-dir | |||
:base-dir base-dir | |||
:images-dir (.resolve (path) base-dir IMAGES-DIR-NAME) | |||
:audios-dir (.resolve (path) base-dir AUDIOS-DIR-NAME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with this change, when I tried to access to :audios-dir
it returns nil
[athens.electron.utils :as electron.utils] | ||
[re-frame.core :as rf])) | ||
|
||
(defn save-audio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the save-image function share a big portion of code, maybe makes sense to refactor the common code to copy files
@@ -98,6 +99,7 @@ strikethrough = <#'~~(?!\\s)'> | |||
|
|||
link = md-link | |||
image = <'!'> md-link | |||
audio = <'^'> md-link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did some copy and paste, but I don't fully understand how the interpreter works
Hi @aldosolorzano, thank you so much for the PR! Some questions around this:
|
Hi @tangjeff0 thank you for answering and sorry for taking long to reply, now I have some time to try again this.
Yes agree with you, I randomly chose that syntax as I could find an standard, to what are you planning to migrate ?
Yes, that's the problem I had, I was able to copy the audio to the athens folder and convert it as
Me and my brother like to record audio from natural places, such as ocean, woods, birds etc... and use them for research and to make music. One day I was talking to him while using athens and it clicked me, I could use athens as a way to share notes over an audio file and not send a whatsapp explaining my idea and then audio. Also as I personal log for adding ideas for the specific recordings and have a centralize place. |
Description
My intent with this PR is to bring a basic support for audio files to athens.
Solution
So far this is what I have;
^[]()
to be used to represent an audio file so that the interpreter can render the audio view correctly.Problems