Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insert markdown link with ctrl/cmd+k when inside block #1879

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tangjeff0
Copy link
Collaborator

@tangjeff0 tangjeff0 commented Nov 27, 2021

@vercel
Copy link

vercel bot commented Nov 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/5AqrQqU1ymEqkk1SHDx1UtGqbLVU
✅ Preview: https://athens-git-fork-tangjeff0-insert-markdown-link-athens-research.vercel.app

@tangjeff0 tangjeff0 changed the title feat: insert markdown link with cmd+k feat: insert markdown link with ctrl/cmd+k when inside block Nov 27, 2021
@neotyk
Copy link
Collaborator

neotyk commented Dec 8, 2021

It's conflicting with Athena invocation.
Can we do some other shortcut for it?

@lukaskawerau
Copy link

It's conflicting with Athena invocation.
Can we do some other shortcut for it?

Cmd-k is the universal shortcut for linking things, including here on Github. Imo Athens should conform to that convention. One option would be that the trigger does different things when a block is focused/you're typing inside a block and when no block is focused.

@tangjeff0
Copy link
Collaborator Author

tangjeff0 commented Dec 9, 2021

Happy medium solution:

  • cmd-p for always-whenever Athena, in any context
  • cmd-k for inserting links when cursor is in a block

Notion does this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants