Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one or more Docker containers for CI #165

Closed
atc0005 opened this issue Nov 19, 2019 · 2 comments · Fixed by #275
Closed

Use one or more Docker containers for CI #165

atc0005 opened this issue Nov 19, 2019 · 2 comments · Fixed by #275
Assignees
@atc0005
Labels
CI question Further information is requested
Milestone
v0.7.8

Comments

@atc0005
Copy link
Owner

atc0005 commented Nov 19, 2019

Example:

https://github.com/stellar/go-xdr/blob/3aa3546/.github/workflows/build.yml

Ref:

actions/setup-go#14

Not sure if it's feasible to use that as I've not checked to see if its easy enough to add the linting tools that we're currently using (e.g., staticcheck) if they're not already bundled in.
@atc0005 atc0005 added question Further information is requested CI labels Nov 19, 2019
@atc0005 atc0005 changed the title Use official Golang Docker container for CI? Use official Docker container for CI Aug 1, 2020
@atc0005 atc0005 added this to the Next Release milestone Aug 1, 2020
@atc0005 atc0005 self-assigned this Aug 1, 2020
@atc0005
Copy link
Owner Author

atc0005 commented Aug 1, 2020

Change in focus. I plan to apply this soon as a follow-up to the work I just completed in atc0005/dnsc#76, atc0005/dnsc#82.

@atc0005 atc0005 pinned this issue Aug 1, 2020
@atc0005 atc0005 changed the title Use official Docker container for CI Use one or more Docker containers for CI Aug 3, 2020
@atc0005
Copy link
Owner Author

atc0005 commented Aug 3, 2020

Change in focus. I plan to apply this soon as a follow-up to the work I just completed in atc0005/dnsc#76, atc0005/dnsc#82.

That work is done and I have a useful set of template files to reference for this work.

atc0005 added a commit that referenced this issue Aug 3, 2020
@atc0005
Use Docker-based GitHub Actions Workflows
547a12d 
Replace native GitHub Actions with containers created
and managed through the `atc0005/go-ci` project.

This results in three workflows:

- New, primary workflow
  - with parallel linting, testing and building tasks
  - with three Go environments
    - "old stable" - currently `Go 1.13.14`
    - "stable" - currently `Go 1.14.6`
    - "unstable" - currently `Go 1.15rc1`
  - Makefile is *not* used in this workflow
  - staticcheck linting using latest stable version
    provided by the `atc0005/go-ci` containers

- Separate Makefile-based linting and building workflow
  - intended to help ensure that local Makefile-based
    builds that are referenced in project README files
    continue to work as advertised until a better local
    tool can be discovered/explored further
  - use `golang:latest` container to allow for Makefile-based
    linting tooling installation testing since the
    `atc0005/go-ci` project provides containers with those
    tools already pre-installed

- Add Quick Validation workflow
  - run on every push, everything else on pull request updates
  - linting via `golangci-lint` only
  - testing
  - no builds

Other changes:

- README
  - Add badges for recent workflows

- Makefile `lintinstall` recipe installs the very latest
  stable version of the `golangci-lint` binary instead
  of locking a specific version
  - this should reduce dependency "gardening"

refs GH-165
@atc0005 atc0005 mentioned this issue Aug 3, 2020
Merged
atc0005 added a commit that referenced this issue Aug 3, 2020
@atc0005
Add missing GitHub Actions Workflows for GH-165
16317ef 
These workflows were intended to be go in with GH-275 for
GH-165.

- `Lint and Build using Makefile`
- `Quick Validation`

- refs GH-165
- refs GH-275
@atc0005 atc0005 mentioned this issue Aug 3, 2020
Merged
atc0005 added a commit that referenced this issue Aug 3, 2020
@atc0005
Merge pull request #276 from atc0005/i165-add-missing-workflows
587644f 
Add missing GitHub Actions Workflows for GH-165
@atc0005 atc0005 unpinned this issue Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
CI question Further information is requested
Projects
None yet
Milestone
v0.7.8
Development

Successfully merging a pull request may close this issue.

Use Docker-based GitHub Actions Workflows atc0005/elbow
1 participant
@atc0005