Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certsum | invalid filename structured logging field #312

Closed
atc0005 opened this issue May 2, 2022 · 0 comments · Fixed by #313
Closed

certsum | invalid filename structured logging field #312

atc0005 opened this issue May 2, 2022 · 0 comments · Fixed by #313
Assignees
@atc0005
Labels
app/certsum bug Something isn't working output/logging
Milestone
v0.7.1

Comments

@atc0005
Copy link
Owner

atc0005 commented May 2, 2022

The filename structured logging field is emitted for the certsum tool.

check-cert/internal/config/logging.go

Line 151 in 7aa1267

Str("filename", c.Filename).

While valid for lscert and check_cert, it is not valid for this tool and should be removed.
@atc0005 atc0005 added bug Something isn't working output/logging app/certsum labels May 2, 2022
@atc0005 atc0005 added this to the Next Release milestone May 2, 2022
@atc0005 atc0005 self-assigned this May 2, 2022
atc0005 added a commit that referenced this issue May 2, 2022
@atc0005
certsum | remove invalid filename logger field
1b67c5c 
The `Config.Filename` field is always empty for the `certsum` tool
as that tool does not accept that flag.

refs GH-312
@atc0005 atc0005 mentioned this issue May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
app/certsum bug Something isn't working output/logging
Projects
None yet
Milestone
v0.7.1
Development

Successfully merging a pull request may close this issue.

certsum | remove invalid filename logger field atc0005/check-cert
1 participant
@atc0005