Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for G2-2.7-eng #63

Open
wants to merge 86 commits into
base: master_vs2015
Choose a base branch
from
Open

Support for G2-2.7-eng #63

wants to merge 86 commits into from

Conversation

kraugug
Copy link

@kraugug kraugug commented Aug 28, 2019

I would like to add support for Gothic 2 v2.7 English binary.

ataulien added 30 commits March 23, 2015 14:01
    Worked around Velocity-Aligned particles looking wrong in some cases (Summoning Goblins)

    Fixed missing ground-shake when casting some spells

    Improved handling of far-plane

    Default WorldSectionDrawDistance is now 4 (Up from 3)

    Gradually fading in lights now

    Fixed leafs disappear in the distance sometimes

    Decals are now drawn back to front (Spiderwebs)

    Improved underwater-effect

    Clearing DepthBuffer now before UI-Rendering so the HUD won't be rendered behind geometry

    Menus are no longer visible in savegame thumbnails
ataulien and others added 24 commits June 14, 2016 21:35
Water Tesselation crash fix
- disabled tesselation per default
- set DrawWorldMesh to 3 ( if <=2 -> worldmesh not visible)
Better render setting defaults for AMD cards, release update
Fix reading resolution from command line
- Disabled F1 EditorPanel as default
- Disabled Tesselation for skeletal meshes
- G1 sky fixed (G1 hooks added, rhw transform fixed, lensflare disabled)
- Sky not writing to depth (so that the world behind the barrier is visible)
- Tesselation will be disabled once, following setting changes will be persisted again
- reduced wetness duration
- reduced diffuse color  changes, normal strength reflection during rain/wetness
fixed color adjustment of vegetation
- adding spaces around __DATE__ fixes msc complaining
- added more detailed build instructions
- removed (D3D11-)PipelieState from BaseGraphicsEngine and D3D11GraphicsEngineBase
- removed leftover deferred stuff
- renamed ShadowedPointLight to BaseShadowedPointLight (can be merged with D3D11PointLight)
- removed GWorldMesh and GMaterial
- fixed most left over VS warnings coming from GD3D11 code
@ataulien
Copy link
Owner

I don't see any commits by you, looks like you're not working with the master branch?

Or is this rather a discussion which should be held in an issue?

Supporting 2.7-eng will be hard if there are no debug-symbols in the executable. Does 2.7-eng come with debug symbols?

@kraugug
Copy link
Author

kraugug commented Aug 29, 2019

Sorry my mistake. I'm quite new with Git and I really should read before what pull request actually means. Anyway I have it already working, but I wanted to somehow ask if I can push the changes. If yes, should I create a new branch?

And luckily 2.7-eng binary has debug symbols, but few changes was needed. I also added some stuff, if it is ok?

Screenshot

@Katharsas
Copy link
Collaborator

Katharsas commented Aug 29, 2019

I think your problem is that you are trying to merge into master_vs2015. You should instead checkout master, make a new branch, make your changes and then make pull request to merge into master, not master_vs2015.

@kraugug
Copy link
Author

kraugug commented Aug 29, 2019

D'oh! That sounds logical. Thanks for the advice.

@ataulien
Copy link
Owner

Oh, that is awesome!

I think your problem is that you are trying to merge into master_vs2015.

@Katharsas He's actually trying to merge the master of ataulien/GD3D11 into master_vs2015, also of ataulien/GD3D11.

@kraugug I suggest you Fork this repository so you have "your own" repository you can work with. From there, you can send the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants