Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Feature request]: Show no play found when there is no match for filter and search result #43

Closed
shrilakshmishastry opened this issue Apr 18, 2022 · 4 comments · Fixed by #94
Closed

✨ [Feature request]: Show no play found when there is no match for filter and search result #43

shrilakshmishastry opened this issue Apr 18, 2022 · 4 comments · Fixed by #94
Assignees
@nirmalkc @hasnainmakada-99

Comments

@shrilakshmishastry
Copy link
Member

Need a feature that shows no play found when there is no match in filter and search result.

Currently, the screen is blank when there is no match found. It would be a good experience if there is some message showing no play match for the applied filter or search
@atapas atapas added the good first issue New-contributor friendly label Apr 18, 2022
@hasnainmakada-99
Copy link
Contributor

Tapas sir, I would like to work on this issue

@atapas
Copy link
Member

atapas commented Apr 19, 2022

Tapas sir, I would like to work on this issue

Ok sure. For design of the page please work with @nirmalkc

@atapas atapas removed the good first issue New-contributor friendly label Apr 19, 2022
@hasnainmakada-99 hasnainmakada-99 mentioned this issue Apr 22, 2022
Merged
5 tasks
@atapas
Copy link
Member

atapas commented Apr 23, 2022

@nirmalkc the code logic is done and in main. Could you please create a branch and style this one? I shall close the issue after that.

@atapas atapas linked a pull request Apr 23, 2022 that will close this issue
Added The Play not found feature #94
Merged
5 tasks
@atapas atapas added the work in progress The work is in progress label Apr 23, 2022
@atapas atapas removed the work in progress The work is in progress label May 1, 2022
@atapas
Copy link
Member

atapas commented May 1, 2022

Styling will be done part of #126

@atapas atapas closed this as completed May 1, 2022
@Angra974 Angra974 mentioned this issue Sep 25, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nirmalkc nirmalkc

@hasnainmakada-99 hasnainmakada-99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added The Play not found feature hasnainmakada-99/react-play
4 participants
@atapas @nirmalkc @shrilakshmishastry @hasnainmakada-99