6.8.2

at-internet · Jan 27, 2023 · 4aaadb0 · 4aaadb0
1 parent 2f79e29
commit 4aaadb0
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 27 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 6.8.2
+### Fixes
+- Fixed an issue preventing various cookies from being deposited when not using Consent
+
 ## 6.8.1
 ### Fixes
 - Consent management was crashing in rare case where no `window.pdl` was set beforehand

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "piano-analytics-js",
   "description": "JavaScript library for Piano Analytics",
-  "version": "6.8.1",
+  "version": "6.8.2",
   "main": "dist/browserless/piano-analytics.cjs.js",
   "module": "dist/browserless/piano-analytics.esm.js",
   "browser": "dist/browser/piano-analytics.umd.js",

diff --git a/src/business/privacy/dl-privacy-configuration.js b/src/business/privacy/dl-privacy-configuration.js
@@ -18,7 +18,15 @@ const baseConfig = {
         'device_timestamp_utc': 'mandatory',
         'visitor_privacy_consent': 'mandatory',
         'visitor_privacy_mode': 'mandatory',
-        'ch_ua*': 'mandatory',
+        'ch_ua': 'mandatory',
+        'ch_ua_arch': 'mandatory',
+        'ch_ua_bitness': 'mandatory',
+        'ch_ua_full_version': 'mandatory',
+        'ch_ua_full_version_list': 'mandatory',
+        'ch_ua_mobile': 'mandatory',
+        'ch_ua_model': 'mandatory',
+        'ch_ua_platform': 'mandatory',
+        'ch_ua_platform_version': 'mandatory',
         'app_crash': 'essential',
         'app_crash_class': 'essential',
         'app_crash_screen': 'essential',

diff --git a/src/business/privacy/dl-privacy.js b/src/business/privacy/dl-privacy.js
@@ -3,6 +3,7 @@ import {dataLayer} from '../data-layer/data-layer';
 import {getConsentItems} from './dl-privacy-configuration';
 
 function DlPrivacy(pa) {
+    const DEFAULT_MODE = 'opt-in';
     this.storageKeys = [
         'pa_vid',
         'pa_user',
@@ -54,40 +55,39 @@ function DlPrivacy(pa) {
             items: this.consentItems.cookieItems
         });
         if(!pa.getConfiguration('isLegacyPrivacy')){
+            this.initMode();
             this.filterKeys();
         }
     };
-
+    this.initMode = function () {
+        if (dataLayer.get('consent') === null) {
+            if (window.pdl.consent && window.pdl.consent.defaultPreset) {
+                dataLayer.set('consent', 0);
+            } else {
+                this.setMode(DEFAULT_MODE);
+            }
+        }
+    };
     /* public */
     this.setMode = function (mode) {
-        _switchToDl();
         dataLayer.set('consent', {
             PA: {mode: mode}
         });
         this.filterKeys();
     };
     this.setPresets = function (presets) {
-        _switchToDl();
         dataLayer.set('consent', presets);
         this.filterKeys();
     };
     this.getMode = function () {
-        _switchToDl();
-        let consent = 'opt-in';
+        let consent = DEFAULT_MODE;
         const dlConsent = dataLayer.get('consent');
         if (dlConsent && dlConsent['PA'] && dlConsent['PA'].mode) {
             consent = dataLayer.get('consent')['PA'].mode;
-        } else if (dlConsent === null) {
-            if (window.pdl.consent && window.pdl.consent.defaultPreset) {
-                dataLayer.set('consent', 0);
-            } else {
-                this.setMode(consent);
-            }
         }
         return consent;
     };
     this.setCustomModeMetadata = function (consentValue, modeName) {
-        _switchToDl();
         this.modeMetadata['custom'].visitor_privacy_mode = modeName || 'custom';
         this.modeMetadata['custom'].visitor_privacy_consent = consentValue;
     };
@@ -139,13 +139,6 @@ function DlPrivacy(pa) {
         }
     };
 
-    function _switchToDl() {
-        if (pa.getConfiguration('isLegacyPrivacy')) {
-            pa.setConfiguration('isLegacyPrivacy', false);
-            pa.consent.filterKeys();
-        }
-    }
-
     this.dl = dataLayer;
 
     this.init();

diff --git a/src/config.js b/src/config.js
@@ -23,7 +23,7 @@ export default {
     ],
     'storageVisitor': 'pa_vid',
     'storageUser': 'pa_user',
-    'version': '6.8.1',
+    'version': '6.8.2',
     'minHeartbeat': 5,
     'minBufferingHeartbeat': 1,
     'queueVarName': '_paq',

diff --git a/src/core/PianoAnalytics.js b/src/core/PianoAnalytics.js
@@ -49,7 +49,6 @@ function _initPrivacy(pa) {
     if (BUILD_BROWSER) {
         if (typeof window.pdl === 'undefined') {
             window.pdl = {
-                requireConsent: true,
                 migration: {
                     browserId: {
                         source: 'PA'
@@ -59,10 +58,7 @@ function _initPrivacy(pa) {
                     storageMode: 'fixed'
                 }
             };
-        } else {
-            if (!window.pdl.requireConsent) {
-                window.pdl.requireConsent = true;
-            }
+        } else if (window.pdl && window.pdl.requireConsent) {
             pa.setConfiguration('isLegacyPrivacy', false);
         }
         dataLayer.init({