Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Huawei classes in release build #12

Closed
OndraBasler opened this issue Oct 23, 2023 · 2 comments
Closed

Missing Huawei classes in release build #12

OndraBasler opened this issue Oct 23, 2023 · 2 comments

Comments

@OndraBasler
Copy link

I have a problem with SDK in release. In debug the application builds fine. The release build crashes during obfuscation by R8.
I think it is cased by missing Huawei SDK that I haven't added because I don't use Huawei id as visitor ID. Is it really optional or I need to add it even though I don't use it?

Missing class com.huawei.hms.ads.identifier.AdvertisingIdClient$Info (referenced from: io.piano.android.analytics.idproviders.AdvertisingIdInfo io.piano.android.analytics.idproviders.HuaweiAdvertisingIDIdProvider.loadAdvertisingInfo$piano_analytics_release())
Missing class com.huawei.hms.ads.identifier.AdvertisingIdClient (referenced from: io.piano.android.analytics.idproviders.AdvertisingIdInfo io.piano.android.analytics.idproviders.HuaweiAdvertisingIDIdProvider.loadAdvertisingInfo$piano_analytics_release())

I have minimal setup

val configuration = Configuration.Builder(
     collectDomain = pianoConfiguration.domain,
     site = pianoConfiguration.siteId.toInt(),
).build()

PianoAnalytics.init(application.applicationContext, configuration)
@DeKaN
Copy link
Contributor

DeKaN commented Oct 23, 2023

Hi @OndraBasler,
you can add -dontwarn com.huawei.hms.ads.** into your proguard rules to fix it. I'll add it into SDK consumer rules in the next release

DeKaN added a commit that referenced this issue Oct 23, 2023
@DeKaN
Copy link
Contributor

DeKaN commented Oct 30, 2023

Rules have been released as part of 3.3.4

@DeKaN DeKaN closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants