Logging #81
Merged
Logging #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Closing in favor of #86 |
* dev: Add CurrentSynchronizationContextDispatcher added nuget section Updated readme with simple initial content ClusterProvider interface cluster skeleton
* commit 'a62d6b203c935c0af1086cca05b1cc81d296856a': Bumped version added sender middleware example Handle null responses in FutureProcess some docs Throw exception when a future gets a message it does not expect. Disable/hide bounded mailbox because it has issues Increase sleep in mailbox tests Re-added lost line of code Reschedule mailbox after completion of non-completed task Fix proj versions Package info
|
@cpx86 reopened this. I have a static logger factory so we don't need to use DI. I was wondering if the log should be moved to Proto.Mailbox or it's own project as Proto.Actor isn't the lowest level library. |
Closed
|
I think Proto.Actor is the best fit. The reason Mailbox is separate is because we want to make it possible to use Mailboxes for other purposes than Actors. But Proto.Actor is really the core library. Having a separate Proto.Logging feels a bit overkill since it probably wouldn't be usable outside of Proto.Actor. |
|
No problem. Then I guess this is ready unless the style isn't liked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a static log object. Instrument some code and use an example.
I recognize this isn't what is discussed in: #18
Essentially, if I try to put an EventStream in I'll have to fan-in from all usages of
ILogger(or some other interface) to the stream and put data in a customLogMessage. Then fan-out again toILoggerto allow usage ofILoggerFactoryand all the logging implementations that use that.Ideally, you want to use
ILoggerorILoggerFactorydirectly in the code to be instrumented. The problem was always how to get one of those objects to the code.An event stream doesn't feel like a fit because the
LoggerFactoryitself is a pub/sub type construct in which all the implementations are subbing to the factory and the code is pubbing.If this doesn't fit the vision at all, that's cool. I guess I just don't see how log messages should be involved in an actual event stream.