feat: support config AddressResolverGroup in r2dbc-mysql #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CennyMo
approved these changes
Jul 24, 2024
hezhangjian
force-pushed
the
support-resovler
branch
from
bec8b00 to
a538d2d
Compare
|
@jchrys PTAL, thanks :) |
jchrys
reviewed
Jul 25, 2024
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java
Show resolved
Hide resolved
hezhangjian
force-pushed
the
support-resovler
branch
from
9d4615d to
f0d5b07
Compare
|
@jchrys Thank you for the reminder. I have fixed. However, I am still undecided on whether to name it resolver or resolverGroup. Do you have any preference? |
jchrys
reviewed
Jul 25, 2024
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java
Outdated
Show resolved
Hide resolved
Consider Reactor netty refers to it as |
hezhangjian
force-pushed
the
support-resovler
branch
from
546876d to
507ed74
Compare
Signed-off-by: ZhangJian He <[email protected]>
hezhangjian
force-pushed
the
support-resovler
branch
from
507ed74 to
8a5e9cc
Compare
jchrys
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Just one last detail: I believe we have one final step to complete. Could you please check the following?
MySqlConnectionConfiguration#equals
MySqlConnectionConfiguration#hashCode
MySqlConnectionConfiguration#toString
MySqlConnectionConfiguration#setup(ConnectionFactoryOptions)
Thank you!
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java
Show resolved
Hide resolved
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java
Show resolved
Hide resolved
…onConfiguration.java Co-authored-by: jchrys <[email protected]> Signed-off-by: ZhangJian He <[email protected]>
…hashCode,MySqlConnectionConfiguration#toString,MySqlConnectionConfigurationProvider#setup(ConnectionFactoryOptions) Signed-off-by: ZhangJian He <[email protected]>
Signed-off-by: ZhangJian He <[email protected]>
|
@jchrys Thanks for your effort. PTAL again |
jchrys
reviewed
Jul 25, 2024
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/client/Client.java
Outdated
Show resolved
Hide resolved
jchrys
reviewed
Jul 25, 2024
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/client/Client.java
Outdated
Show resolved
Hide resolved
jchrys
reviewed
Jul 25, 2024
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/client/Client.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jchrys <[email protected]> Signed-off-by: ZhangJian He <[email protected]>
jchrys
reviewed
Jul 25, 2024
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionFactoryProvider.java
Outdated
Show resolved
Hide resolved
…onFactoryProvider.java Co-authored-by: jchrys <[email protected]> Signed-off-by: ZhangJian He <[email protected]>
jchrys
reviewed
Jul 25, 2024
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java
Outdated
Show resolved
Hide resolved
…onConfiguration.java Co-authored-by: jchrys <[email protected]> Signed-off-by: ZhangJian He <[email protected]>
Signed-off-by: jchrys <[email protected]>
jchrys
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently,
AddressResolverGroupcan't be configured. The DnsResolver default start address listen to "0.0.0.0", which may have some security risks.also see netty/netty#11061
Modification:
Add
AddressResolverGroupin Client's connect method