Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing option localInfileBufferSize #237

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add missing option localInfileBufferSize #237

merged 1 commit into from
Feb 16, 2024

Conversation

mirromutth
Copy link
Contributor

Motivation:

The option localInfileBufferSize is missing in MySqlConfigurationFactoryProvider.

Modification:

  • Add missing option
  • Add unit tests for checking missing options/items between MySqlConfigurationFactoryProvider and MySqlConnectionConfiguration

Result:

Added missing option

@mirromutth mirromutth added this to the 1.1.2 milestone Feb 16, 2024
@mirromutth mirromutth requested a review from jchrys February 16, 2024 05:29
jchrys
jchrys approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirromutth mirromutth merged commit 6c109b6 into trunk Feb 16, 2024
14 checks passed
@mirromutth mirromutth deleted the fix/missing-options branch February 16, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchrys jchrys jchrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mirromutth @jchrys