-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for parameters #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
However, I'm concerned about the breaking change(*MySqlParameter#toString
exposes its value, Debug level Query Logger exposes params). Suggest merging with the next minor version update or log with params only when trace level is enabled. Let's discuss before merging.
I fixed a little miss in the README, and I added an override of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f6b099f
to
93ffaba
Compare
93ffaba
to
95cb678
Compare
- Correct parameter interface from `Parameter` to `MySqlParameter` - Override `toString()` in the implementation of `MySqlParameter`
95cb678
to
26db184
Compare
Motivation:
See also #138 .
When driver executing a text statement (no binding), log will like:
When user is using client-preparing statements, log will like:
When user is using server-preparing statements, log will like:
Modification:
AbstractMySqlParameter
need to overridetoString
.Result:
More human-friendly SQL debugging logging.