-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PNPM #1088
Use PNPM #1088
Conversation
🦋 Changeset detectedLatest commit: b5d49c3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for studio-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Amzani @Shurtu-gal. PR is ready to review.
|
@KhudaDad414 there are some conflicts |
@Shurtu-gal the conflicts has been resolved. |
/ptal |
@Amzani @magicmatatjahu @princerajpoot20 Please take a look at this PR. Thanks! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KhudaDad414 could we not have changes in GitHub workflows as it is something managed from .github
repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately we can't. .github
only supports npm
.
if everything goes well, we can purpose our changes to .github
repo and make sure other packages in AsyncAPI can also use pnpm
as their package manager.
I have also removed the nodejs
tag which makes sure that we do not get updates for the test script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine I was only speaking about this specific file but as it is the same with the .github
one there is no issue. I guess I was seeing commit diff leading to this file being shown as modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only small change regarding this sentence in the README
Note: NPM v7+ is required.
Change to pnpm
@Amzani done. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rtm |
Co-authored-by: asyncapi-bot <[email protected]>
/help |
Hello, @derberg! 👋🏼
|
Description
nodejs
tag from the repo after merge