Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: port server-variable model to ts #507

Merged
merged 4 commits into from
Apr 4, 2022
Merged

refactor: port server-variable model to ts #507

merged 4 commits into from
Apr 4, 2022

Conversation

Souvikns
Copy link
Member

Description

Porting server-variable object to typescript.

Related issue(s)

See also #482

@Souvikns Souvikns marked this pull request as ready for review March 29, 2022 05:04
magicmatatjahu
magicmatatjahu reviewed Apr 1, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two improvements :) Overall good.

src/models/v2/server.ts Outdated Show resolved Hide resolved
src/models/v3/server.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 30 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Souvikns
Copy link
Member Author

Souvikns commented Apr 1, 2022

Well, there are 30 code smells, all Unnecessary semicolon.

magicmatatjahu
magicmatatjahu approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@magicmatatjahu
Copy link
Member

Well, there are 30 code smells, all Unnecessary semicolon.

Atm it's not the problem :) We will resolve that issues with eslint.

@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @magicmatatjahu! 👋🏼
This PR is not up to date with the base branch and can't be merged.
You can add comment to this PR with text: /autoupdate or /au. This way you ask our bot to perform regular updates for you. The only requirement for this to work is to enable Allow edits from maintainers option in your PR. Otherwise the only option that you have is to manually update your branch with latest version of the base branch.
Thanks 😄

@asyncapi-bot asyncapi-bot merged commit 032735b into asyncapi:next-major Apr 4, 2022
magicmatatjahu pushed a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
@Souvikns @magicmatatjahu
refactor: port server-variable model to ts (asyncapi#507)
f0aabee
derberg pushed a commit that referenced this pull request Oct 4, 2022
@Souvikns @derberg
refactor: port server-variable model to ts (#507)
49afdba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Souvikns @magicmatatjahu @asyncapi-bot