Implement API #12
Merged
Implement API #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmvilas
force-pushed
the
feature/implement-api
branch
from
ae03850 to
614fbf0
Compare
fmvilas
force-pushed
the
feature/implement-api
branch
3 times, most recently
from
2bb3cd9 to
3f4b31a
Compare
fmvilas
force-pushed
the
feature/implement-api
branch
from
3f4b31a to
35b84d5
Compare
This was referenced Aug 14, 2019
|
I'm moving forward and gonna merge this PR. Please, if you see something wrong, missing, or just don't agree with the changes, don't hesitate to leave a comment after it's merged. I'll be happy to address these questions afterward. |
|
I started the review but then got lost in changes. This PR was HUGE. |
|
I know. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
Note: I recommend to start reviewing the PR from the README.md file, then the API.md, and then the code.