chore: infer name for object schema

[magicmatatjahu]

Description

• reflect names of declarations, definitions, properties by propertyName and save them in x-modelgen-inferred-name, then infer this name to $id CommonModel's property
• update tests

Related issue(s)
See also asyncapi/shape-up-process#45

[jonaslagoni]

Most of the things looks good I however got a few things that needs to be addressed first:

• Does it really make sense to call it originalSchema anymore? since it is no longer the original but a modified version?
• Does it make sense to have $id as part of the CommonModel anymore since your new name kinda replaces this right? This also means you can remove the anonymous schema id naming functionality.
• Skipped tests need to be unskipped
• I would love to see unit tests for this function instead of relying on integration tests to show it.

[magicmatatjahu]

@jonaslagoni Thanks for review!

Does it really make sense to call it originalSchema anymore? since it is no longer the original but a modified version?

I know, but we have an architectural problem. As you know we have this problem with additional iteration in toSchema function, and I don't know why. If I add name extension after toSchema, then I had a problem naming, because in one test as I remember in extension I had a test name and should be street_name etc, so I cannot add naming after writing schema to originalSchema.

Also extension shouldn't be treated as changing schema -> this same we make inside our parser-js.

[magicmatatjahu]

@jonaslagoni I removed name and save name to $id and also added missing test for new function.

[jonaslagoni]

So my requirement for this infer name is that name is unique for all schemas, this might be wrong, but then I dont see how we can use this in replacement of the anon schema naming?

[jonaslagoni]

Just have two comments, looking great overall!

[jonaslagoni]

🥳

[asyncapi-bot]

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀