Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix coverage problems with checkout #592

Merged

Conversation

jonaslagoni
Copy link
Member

Description
Sometimes, the CI check fails, for weird reasons, almost because it can't find the coverage report, apparently, it is the fault of checkout@v1. coverallsapp/github-action#55

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1708109525

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.584%

Totals Coverage Status
Change from base Build 1705787454: 0.0%
Covered Lines: 2371
Relevant Lines: 2417

💛 - Coveralls

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonaslagoni jonaslagoni merged commit 88cf92d into asyncapi:master Jan 17, 2022
@jonaslagoni jonaslagoni deleted the feature/fix_coverage_problem branch January 17, 2022 13:41
@jonaslagoni jonaslagoni restored the feature/fix_coverage_problem branch January 23, 2022 14:36
@jonaslagoni jonaslagoni deleted the feature/fix_coverage_problem branch January 23, 2022 14:37
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants