-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add python runtime tests #1748
Conversation
✅ Deploy Preview for modelina canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
@jonaslagoni , can you review this PR |
Pull Request Test Coverage Report for Build 8453039650Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's focus on making the workflow succeed 🙂
@jonaslagoni , thank you for the reviews, added new changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there it seems 👍
@AkhilJ321 have you had time to take a look at the problem above? |
yes, tried debugging it in execCommand code also, guess its some issue with the way Python tests give output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After manually running your test command, you should be able to get the exit code from the command using echo $?
to check whether it is a problem i.e. that it returns 1 when tests are successful.
It also slightly looks like that there is an exception thrown that the test ignores (based on the CI logs) |
|
@AkhilJ321 have you giving up on the effort here? |
Sorry for not reaching out to you. There is thing I am confused about: |
It returns 0 on successful execution |
|
|
Awesome @AkhilJ321 ✌️ |
@all-contributors please add @AkhilJ321 for code, test |
I've put up a pull request to add @AkhilJ321! 🎉 |
🎉 This PR is included in version 3.4.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.0.0-next.36 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Added runtime tests for python
Related Issue
Fixes #1745