Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update for Intellij 2023.1 #27

Merged
merged 5 commits into from
May 1, 2023

Conversation

nexoscp
Copy link
Contributor

@nexoscp nexoscp commented Apr 21, 2023

Update for Intellij 2023.1

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Pakisan
Copy link
Member

Pakisan commented Apr 21, 2023

@nexoscp hi!

I didn't merge release/2.0.0 into master, that's why you have conflicts. Please re-target your mr to branch, which I created for you - release/2.1.0

UPD: I changed master to release/2.1.0 by my self

@Pakisan Pakisan changed the base branch from master to release/2.1.0 April 21, 2023 21:51
}

group = "com.asyncapi.plugin.idea"
version = "2.0.0+jre17"
version = "2.0.1+jre17"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's new feature, not bug fix. Please change to 2.1.0

plugins.set(listOf("yaml"))
}
tasks.getByName<org.jetbrains.intellij.tasks.PatchPluginXmlTask>("patchPluginXml") {
sinceBuild.set("223")
untilBuild.set("223.*")
sinceBuild.set("231")
Copy link
Member

@Pakisan Pakisan Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you replace sinceBuild.set("223") with sinceBuild.set("231"), users on 2022.3.* will not receive any new updates.

Did you find some compatibility problems?

@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-rc-1-bin.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version of gradle is out. I propose to you to change this RC version to stable one - 8.1.1

@alvesf2
Copy link

alvesf2 commented Apr 27, 2023

Hello everybody. Do you have any estimation of when this will be in production?

Also,
image
These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.

Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.

Cheers! 🙇

@Pakisan Pakisan changed the title WIP: chore: update for Intellij 2023.1 feat: update for Intellij 2023.1 May 1, 2023
@Pakisan Pakisan merged commit 4395a6f into asyncapi:release/2.1.0 May 1, 2023
@Pakisan
Copy link
Member

Pakisan commented May 1, 2023

Hello everybody. Do you have any estimation of when this will be in production?

Also, image These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.

Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.

Cheers! 🙇

Hi @alvesf2

I Will make the proposed changes, by myself, run check compatibility tests, and send them to review today evening(02.05)

@alvesf2
Copy link

alvesf2 commented May 6, 2023

Hello everybody. Do you have any estimation of when this will be in production?
Also, image These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.
Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.
Cheers! 🙇

Hi @alvesf2

I Will make the proposed changes, by myself, run check compatibility tests, and send them to review today evening(02.05)

Hi, again @Pakisan Usually how long does it take for IntelliJ to validate these changes?

Thank you,
Fábio

@Pakisan
Copy link
Member

Pakisan commented May 9, 2023

Hello everybody. Do you have any estimation of when this will be in production?
Also, image These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.
Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.
Cheers! 🙇

Hi @alvesf2
I Will make the proposed changes, by myself, run check compatibility tests, and send them to review today evening(02.05)

Hi, again @Pakisan Usually how long does it take for IntelliJ to validate these changes?

Thank you, Fábio

Hi!

The review may take up to two business days (Monday - Friday, CET timezone, excluding official holidays). You will get a response on the Email used to register in the Marketplace. If you have any questions or feedback, please reach out to the Support team at

I missed with release channel. Re-targeted release to stable now.

You can download the plugin and install it manually from the release page. I pushed all changes to the release branch and attached .jar, .zip

@Pakisan
Copy link
Member

Pakisan commented May 9, 2023

Hello everybody. Do you have any estimation of when this will be in production?
Also, image These links take us to the old repository (https://github.com/Pakisan/jasyncapi-idea-plugin), not this one. It would be nice to update this.
Apologies for commenting on the PR, but seems like there isn't an issue open to track this work.
Cheers! 🙇

Hi @alvesf2
I Will make the proposed changes, by myself, run check compatibility tests, and send them to review today evening(02.05)

Hi, again @Pakisan Usually how long does it take for IntelliJ to validate these changes?

Thank you, Fábio

Release was approved and available now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants