-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add workflow for automated vote notification #1337
Conversation
/u |
/ptal |
@derberg @thulieblack Please take a look at this PR. Thanks! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shurtu-gal left few comments, thanks a lot!
I think it is ok to make first version based on slack, and in the meantime we need to discuss with TSC if they feel fine sharing emails openly in maintainers.yml
Co-authored-by: Lukasz Gornicki <[email protected]>
Signed-off-by: Ashish Padhy <[email protected]>
@derberg sorry for stretching this out. I have made the requested changes:
|
I was having a test bench where I was doing it. Let me bring it up again. |
Signed-off-by: Ashish Padhy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, after refactor it is so much easier to read and review 🙏🏼 great job!
Signed-off-by: Ashish Padhy <[email protected]>
Signed-off-by: Ashish Padhy <[email protected]>
Signed-off-by: Ashish Padhy <[email protected]>
* | ||
* @returns {Boolean} true if Slack notification sent successfully, false otherwise | ||
*/ | ||
async function sendSlackNotification(member, issue, daysBeforeDeadline, slackToken) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
daysBeforeDeadline
as discussed in another comment - predicting deadline is difficult, so please change a message to tell the voter, how much time passed since the voting request was sent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Ashish Padhy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, lets test in production!
on Friday I'll kick of voting on the budget so in 2 weeks we will have some results
/rtm |
@all-contributors please add @Shurtu-gal for infra, review, question, ideas, maintenance |
I've put up a pull request to add @Shurtu-gal! 🎉 |
Description
Related issue(s)
Closes #1163