Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow for automated vote notification #1337

Merged
merged 15 commits into from
Feb 12, 2025

Conversation

Shurtu-gal
Copy link
Contributor

Description

  • Checks current votes and sends weekly notification to pending members.

Related issue(s)
Closes #1163

@Shurtu-gal
Copy link
Contributor Author

/u

@Shurtu-gal Shurtu-gal self-assigned this Aug 15, 2024
@Shurtu-gal
Copy link
Contributor Author

Sample message:
image

@Shurtu-gal Shurtu-gal marked this pull request as ready for review August 15, 2024 06:58
@Shurtu-gal
Copy link
Contributor Author

/ptal

@asyncapi-bot
Copy link
Contributor

@derberg @thulieblack Please take a look at this PR. Thanks! 👋

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shurtu-gal left few comments, thanks a lot!

I think it is ok to make first version based on slack, and in the meantime we need to discuss with TSC if they feel fine sharing emails openly in maintainers.yml

@Shurtu-gal Shurtu-gal requested a review from derberg October 21, 2024 16:30
@Shurtu-gal Shurtu-gal changed the title feat: add workflow for automated vote notification ci: add workflow for automated vote notification Feb 9, 2025
@Shurtu-gal
Copy link
Contributor Author

@derberg sorry for stretching this out. I have made the requested changes:

  • Added proper desc wherever necessary.
  • Added proper error handling.
  • Filters only those members which have a slack id now, as many people don't have currently.

@Shurtu-gal Shurtu-gal requested a review from derberg February 9, 2025 17:59
@Shurtu-gal
Copy link
Contributor Author

also wondering how we can test it before merging 🤔

I was having a test bench where I was doing it. Let me bring it up again.
https://github.com/ash17290/asyncapi-community/actions/workflows/vote-notify.yml

@Shurtu-gal Shurtu-gal requested a review from derberg February 10, 2025 20:38
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, after refactor it is so much easier to read and review 🙏🏼 great job!

.github/workflows/vote-notify.yml Outdated Show resolved Hide resolved
.github/workflows/vote-notify-helpers/index.js Outdated Show resolved Hide resolved
.github/workflows/vote-notify-helpers/index.js Outdated Show resolved Hide resolved
.github/workflows/vote-notify.yml Outdated Show resolved Hide resolved
.github/workflows/vote-notify.yml Outdated Show resolved Hide resolved
@Shurtu-gal Shurtu-gal requested a review from derberg February 12, 2025 10:02
*
* @returns {Boolean} true if Slack notification sent successfully, false otherwise
*/
async function sendSlackNotification(member, issue, daysBeforeDeadline, slackToken) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

daysBeforeDeadline

as discussed in another comment - predicting deadline is difficult, so please change a message to tell the voter, how much time passed since the voting request was sent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Shurtu-gal Shurtu-gal requested a review from derberg February 12, 2025 14:01
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets test in production!

on Friday I'll kick of voting on the budget so in 2 weeks we will have some results

@derberg
Copy link
Member

derberg commented Feb 12, 2025

/rtm

@asyncapi-bot asyncapi-bot merged commit 516142d into asyncapi:master Feb 12, 2025
8 checks passed
@Shurtu-gal Shurtu-gal deleted the vote-notify branch February 12, 2025 16:17
@derberg
Copy link
Member

derberg commented Feb 12, 2025

@all-contributors please add @Shurtu-gal for infra, review, question, ideas, maintenance

Copy link
Contributor

@derberg

I've put up a pull request to add @Shurtu-gal! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create a new notification workflow that notifies the TSC Members to particpate in voting process
4 participants