-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch to parser-js in most places #264
refactor: switch to parser-js in most places #264
Conversation
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, Maciej! 👏
BTW, I think the beautifying process should be removed entirely. Not on this PR but at some point during the cycle. As it is right now, there are a couple of things that are not needed or incorrect:
|
I mentioned about removing this process in sentence 😄 :
I used React Markdown component in previous job and it's awesome, but this is a nice-to-have feature in unification :) We can stay with |
@magicmatatjahu I would just change commit scope to |
@derberg Done :) |
🎉 This PR is included in version 0.21.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Changes proposed in this pull request:
parser-js
inInfo
,Servers
(also in singleServer
),Channels
(also in singleChannel
),Messages
(also in singleMessage
),Schemas
components,Schema
component, because it is the most complicated component in package and it should be rewritten with Render missed parts in react-component that are showed in HTML template shape-up-process#87 task - also by this I left some code related to "beautify" our schema - ifSchema
component will be rewritten, we will remove about leftover 10-15% of code.unify-component
branch :)Related issue(s)
Part of asyncapi/shape-up-process#85