ci: cleanup release workflow #218
Conversation
|
don't worry about failing job about PR notification - it is because on PR from fork I cannot modify PR workflow and expect to have access to secrets |
| - name: Install latest version of library in the web-component | ||
| # sleep for 60 seconds before using latest version in web-component, because sometimes NPM needs additional few seconds to `save` package in registry | ||
| run: | | ||
| sleep 1m |
There was a problem hiding this comment.
As I understand, this script will run parallel with if-nodejs-release.yml and for that we have 1m sleep? Another question: What about bumping versions? As I understand from scripts, we will have 2 extra commits with bumps on master: first for react-component, then for playground and web-component, yes?
There was a problem hiding this comment.
Sleep was there already, we needed it no matter if it is in the release workflow or here in the new one.
They do not run in parallel. The release is first as it is triggered by the push to master. This workflow starts when the last step of the release finish (GitHub release creation). In theory, no sleep needed, but you remember we had this problem with "moment of publish to npm" vs "when it is actually available for install"
There was a problem hiding this comment.
So if-nodejs-release.yml and release-wc-and-playground.yml won't be triggered in this same time?
There was a problem hiding this comment.
tl;dr no 😄
if-nodejs-release.yml is triggered on push to master, and release-wc-and-playground.yml on release. So the 2nd one will be triggered once this creates a release
while writing this comment I realized release-wc-and-playground.yml is now triggered on push and not release 😅 pushing fix in a minute
…n playground and webcomponent
|
@magicmatatjahu I just pushed a fix for the problem of not saving in git info about latest react component used in web component and playground. What do you think? |
|
@derberg As I see, you run |
|
@magicmatatjahu yes, in the workflow about release it is needed for release purpose, but this information is not later pushed to the repo. This is what the other workflow does |
|
@magicmatatjahu if you are waiting for |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 0.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is a specific PR where we will not only introduce workflows that are core for this project, but also workflows that will be managed by global config in .github repo. The reason is = to test those workflows in a complex project before we know we can roll it out to others
Changes proposed in this pull request:
The files that you can ignore in review as they are marked with a comment as global and they are 1:1 taken from this and that PR:
.github/workflows/if-nodejs-pr-testing.yml.github/workflows/if-nodejs-release.yml.github/workflows/if-nodejs-version-bump.yml.github/workflows/issues-prs-notifications.yml.github/workflows/release-announcements.ymlissue of having specific
npm run bootstrapsolved with usage of npm lifecycle script,postinstallthat is always triggered after installation of the package. So after doingnpm installthis is what I can see nowissue with additional steps for web component and playground mitigated and moved to a separate workflow that reacts on release event
issue with specific
npm run build-libraryandnpm run build-webcomponentmitigated withprepublishOnlyscript that triggers bothand version bump can be done in global workflow for bumps by introducing